Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix chromeos tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.js
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
index f44f0b39468c90428285b454ba57ca9dba33ea38..594065be69252efba89d4457e480aafe94863932 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
@@ -73,26 +73,11 @@ Polymer({
*/
onTapCategory: function(event) {
var category = event.currentTarget.getAttribute('category');
- if (category == settings.ALL_SITES) {
- this.currentRoute = {
- page: this.currentRoute.page,
- section: 'privacy',
- subpage: ['site-settings', 'all-sites'],
- };
- } else if (category == this.ContentSettingsTypes.PROTOCOL_HANDLERS) {
- this.currentRoute = {
- page: this.currentRoute.page,
- section: 'privacy',
- subpage: ['site-settings', 'protocol-handlers'],
- };
- } else {
- this.categorySelected = this.computeCategoryTextId(category);
- this.currentRoute = {
- page: this.currentRoute.page,
- section: 'privacy',
- subpage: ['site-settings', 'site-settings-category-' +
- this.categorySelected],
- };
- }
+ if (category == settings.ALL_SITES)
+ settings.navigateTo(settings.Route.SITE_SETTINGS_ALL);
+ else if (category == this.ContentSettingsTypes.PROTOCOL_HANDLERS)
+ settings.navigateTo(settings.Route.SITE_SETTINGS_HANDLERS);
+ else
+ settings.navigateTo(this.computeCategoryRoute(category));
},
});

Powered by Google App Engine
This is Rietveld 408576698