Fix glDrawBuffers(0, ...) on main framebuffer

Fix glDrawBuffers(0, ...) on main framebuffer

BUG=629004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/19ea5e66d31e815c7689977de71222e1b0984c92
Cr-Commit-Position: refs/heads/master@{#406138}

[piman, 2016-07-18 21:48:36]

Description was changed from

==========
Fix glDrawBuffers(0, ...) on main framebuffer

BUG=629004
==========

to

==========
Fix glDrawBuffers(0, ...) on main framebuffer

BUG=629004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-07-18 21:48:46]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[piman, 2016-07-18 21:48:55]

piman@chromium.org changed reviewers:
+ zmo@chromium.org

[commit-bot: I haz the power, 2016-07-18 21:50:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-07-18 21:54:26]

https://codereview.chromium.org/2156393002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2156393002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:15852: if (count == 0) {
Actually count have to be 1.  So you should just modify the below condition
count > 1 to count != 1.

[piman, 2016-07-18 21:58:35]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[piman, 2016-07-18 21:58:38]

PTAL.

https://codereview.chromium.org/2156393002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2156393002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:15852: if (count == 0) {
On 2016/07/18 21:54:25, Zhenyao Mo wrote:
> Actually count have to be 1.  So you should just modify the below condition
> count > 1 to count != 1.

Ah, you're right, I read too quickly.

[commit-bot: I haz the power, 2016-07-18 21:59:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-07-18 22:04:12]

On 2016/07/18 21:58:38, piman OOO back 2016-7-18 wrote:
> PTAL.
> 
>
https://codereview.chromium.org/2156393002/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2156393002/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:15852: if (count == 0) {
> On 2016/07/18 21:54:25, Zhenyao Mo wrote:
> > Actually count have to be 1.  So you should just modify the below condition
> > count > 1 to count != 1.
> 
> Ah, you're right, I read too quickly.

lgtm

[piman, 2016-07-18 22:10:32]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-07-18 22:10:36]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:11:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:38:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-18 23:38:40]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 23:40:53]

Description was changed from

==========
Fix glDrawBuffers(0, ...) on main framebuffer

BUG=629004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix glDrawBuffers(0, ...) on main framebuffer

BUG=629004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/19ea5e66d31e815c7689977de71222e1b0984c92
Cr-Commit-Position: refs/heads/master@{#406138}
==========

[commit-bot: I haz the power, 2016-07-18 23:40:54]

Patchset 2 (id:??) landed as
https://crrev.com/19ea5e66d31e815c7689977de71222e1b0984c92
Cr-Commit-Position: refs/heads/master@{#406138}