gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 2156393002: Fix glDrawBuffers(0, ...) on main framebuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2156393002: Fix glDrawBuffers(0, ...) on main framebuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: correct semantics Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index 670782ecb6243bb97252cfe4918b8eb3cc585274..c45494d9de9246bbb2ae2c182698849e6c67977c 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -15849,7 +15849,7 @@ void GLES2DecoderImpl::DoDrawBuffersEXT(

glDrawBuffersARB(count, bufs);

framebuffer->SetDrawBuffers(count, bufs);

} else { // backbuffer

- if (count > 1 ||

+ if (count != 1 ||

(bufs[0] != GL_BACK && bufs[0] != GL_NONE)) {

LOCAL_SET_GL_ERROR(

GL_INVALID_OPERATION,

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc » ('j') | no next file with comments »