Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2156383002: Avoid some string copies in RAPPOR code. (Closed)

Created:
4 years, 5 months ago by Alexei Svitkine (slow)
Modified:
4 years, 5 months ago
Reviewers:
Steven Holte
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid some string copies in RAPPOR code. I remembered some RAPPOR tasks being Janky and looked at sampling profiler data for this code and noticed there was a lot of string copies. This CL makes some intermediate parts use StringPiece to avoid some copies. There's still more copies to go, but this should reduce how many we need. BUG=none Committed: https://crrev.com/0037e42c128122bd4ebdf73a135439198f52cdcc Cr-Commit-Position: refs/heads/master@{#406125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M components/rappor/byte_vector_utils.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/rappor/byte_vector_utils.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M components/rappor/reports.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Alexei Svitkine (slow)
4 years, 5 months ago (2016-07-18 21:18:49 UTC) #2
Steven Holte
lgtm
4 years, 5 months ago (2016-07-18 21:23:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156383002/1
4 years, 5 months ago (2016-07-18 21:33:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 22:38:05 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 22:38:15 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 22:39:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0037e42c128122bd4ebdf73a135439198f52cdcc
Cr-Commit-Position: refs/heads/master@{#406125}

Powered by Google App Engine
This is Rietveld 408576698