Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: components/rappor/byte_vector_utils.h

Issue 2156383002: Avoid some string copies in RAPPOR code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/rappor/byte_vector_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/rappor/byte_vector_utils.h
diff --git a/components/rappor/byte_vector_utils.h b/components/rappor/byte_vector_utils.h
index 73775528044ab18117d5861813d9e86c2c2c08a6..71ce88f49438b320c192a46b5ef052a1708c1a14 100644
--- a/components/rappor/byte_vector_utils.h
+++ b/components/rappor/byte_vector_utils.h
@@ -11,6 +11,7 @@
#include <vector>
#include "base/macros.h"
+#include "base/strings/string_piece.h"
#include "components/rappor/rappor_parameters.h"
#include "crypto/hmac.h"
@@ -83,7 +84,7 @@ class HmacByteVectorGenerator : public ByteVectorGenerator {
// number generator. The string parameters are treated as byte arrays.
HmacByteVectorGenerator(size_t byte_count,
const std::string& entropy_input,
- const std::string& personalization_string);
+ base::StringPiece personalization_string);
~HmacByteVectorGenerator() override;
« no previous file with comments | « no previous file | components/rappor/byte_vector_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698