Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2156303003: Mojo C++ bindings: make the generator use STL/WTF string/vector/map by default. (Closed)

Created:
4 years, 5 months ago by yzshen1
Modified:
4 years, 5 months ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, dominickn+watch_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, rjkroege, hidehiko+watch_chromium.org, blink-reviews, browser-components-watch_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, scheib+watch_chromium.org, kmarshall+watch-blimp_chromium.org, alokp+watch_chromium.org, ben+mojo_chromium.org, shaktisahu+watch-blimp_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, Matt Giuca, yusukes+watch_chromium.org, tdresser+watch_chromium.org, jam, dglazkov+blink, abarth-chromium, Peter Beverloo, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, vabr+watchlistautofill_chromium.org, kalyank, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, tapted, rouslan+autofill_chromium.org, timvolodine, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, estade+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, James Su, darin (slow to review), khushalsagar+watch-blimp_chromium.org, elijahtaylor+arcwatch_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, media-router+watch_chromium.org, tfarina, chromium-apps-reviews_chromium.org, jdonnelly+autofillwatch_chromium.org, Aaron Boodman, ortuno+watch_chromium.org, lhchavez+watch_chromium.org, cc-bugs_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: make the generator use STL/WTF string/vector/map by default. This CL flips the default value of use_new_wrapper_types from "false" to "true". BUG=624136 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/4e4d53c69188102853c17db8c1d6041f3559a9f2 Cr-Commit-Position: refs/heads/master@{#406224}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into 72_switch_default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -24 lines) Patch
M ash/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/sysui/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/engine/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/ipc/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M cc/ipc/cc_ipc.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/media/router/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/engagement/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/plugins/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_web_ui_mojo_bindings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/arc.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M components/autofill/content/public/interfaces/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M components/contextual_search.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/contextual_search/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/dom_distiller.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/dom_distiller/content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/filesystem/filesystem.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/filesystem/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/font_service/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/leveldb/leveldb.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/leveldb/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/memory_coordinator.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/memory_coordinator/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/content/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/safe_json.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_json/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/startup_metric_utils.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/startup_metric_utils/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/web_cache.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/web_cache/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/webmessaging.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M components/webmessaging/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M device/battery/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/battery/battery.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M device/bluetooth/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/nfc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/nfc/nfc.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M device/sensors/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/sensors/sensors.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M device/serial/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/serial/serial.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M device/usb/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/usb/usb.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M device/vibration/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/vibration/vibration.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M device/vr/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/vr/vr.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/api/api.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/ipc.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M mash/init/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/login/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/session/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/shelf/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 5 chunks +9 lines, -0 lines 0 comments Download
M mojo/common/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/mojo_base.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/mojo_edk_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_public.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_public_tests.gyp View 6 chunks +0 lines, -8 lines 0 comments Download
M mojo/mojom_bindings_generator.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojom_bindings_generator_explicit.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 9 chunks +0 lines, -10 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 2 chunks +2 lines, -3 lines 0 comments Download
M net/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M services/catalog/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/navigation/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/shell/background/tests/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/shell/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/shell/shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/shell_public.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/tests/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/shell/tests/connect/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/shell/tests/lifecycle/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/shell/tests/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/shell/tests/shutdown/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/tracing/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/tracing/tracing.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/gpu/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/input_devices/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/user/public/interfaces/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/user/user.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M skia/public/interfaces/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M skia/skia.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/app_list/presenter/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/devices/mojo/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/events/mojo/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gfx/geometry/mojo/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/mojo/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/platform_window/mojo/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M url/mojo/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M url/url.gyp View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
4 years, 5 months ago (2016-07-18 20:58:51 UTC) #4
jam
lgtm
4 years, 5 months ago (2016-07-18 23:52:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156303003/1
4 years, 5 months ago (2016-07-19 00:08:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/220169)
4 years, 5 months ago (2016-07-19 00:20:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156303003/20001
4 years, 5 months ago (2016-07-19 05:05:13 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/220339)
4 years, 5 months ago (2016-07-19 05:17:22 UTC) #18
dcheng
rs lgtm for gpu/ipc/common. Thanks for doing this!
4 years, 5 months ago (2016-07-19 06:03:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156303003/20001
4 years, 5 months ago (2016-07-19 06:04:36 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 06:56:57 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 06:57:01 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 06:58:17 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e4d53c69188102853c17db8c1d6041f3559a9f2
Cr-Commit-Position: refs/heads/master@{#406224}

Powered by Google App Engine
This is Rietveld 408576698