Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3881)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 2156303003: Mojo C++ bindings: make the generator use STL/WTF string/vector/map by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into 72_switch_default Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | net/interfaces/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index d6f4f17c8a05a48b056928736318248d3430bd02..29da6bebc81933b2943a1e877122be79ac8d4a7d 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -74,9 +74,8 @@ foreach(configuration, _bindings_configurations) {
# If set to true, mojom array/map/string will be mapped to STL (for
# chromium variant) or WTF (for blink) types. Otherwise, they will be
# mapped to mojo::Array/Map/String/etc.
-# Default value is false.
+# Default value is true.
# TODO(yzshen):
-# - flip the flag and make use_new_wrapper_types=true the default;
# - convert all users to use the new mode;
# - remove support for the old mode.
template("mojom") {
@@ -230,7 +229,7 @@ template("mojom") {
args += [ "--for_blink" ]
}
- if (defined(invoker.use_new_wrapper_types) &&
+ if (!defined(invoker.use_new_wrapper_types) ||
invoker.use_new_wrapper_types) {
args += [ "--use_new_wrapper_types" ]
}
« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | net/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698