Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: src/builtins/builtins-global.cc

Issue 2156303002: Implement new Function.prototype.toString and fix CreateDynamicFunction parsing (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins/builtins-global.cc
diff --git a/src/builtins/builtins-global.cc b/src/builtins/builtins-global.cc
index 27d2d3b8b3445bb45c59a5e714341e68ffdd06fe..2185f5f086df0a89d5e1373659fbb8aa71d67928 100644
--- a/src/builtins/builtins-global.cc
+++ b/src/builtins/builtins-global.cc
@@ -92,9 +92,10 @@ BUILTIN(GlobalEval) {
}
Handle<JSFunction> function;
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, function, Compiler::GetFunctionFromString(
- handle(target->native_context(), isolate),
- Handle<String>::cast(x), NO_PARSE_RESTRICTION));
+ isolate, function,
+ Compiler::GetFunctionFromString(handle(target->native_context(), isolate),
+ Handle<String>::cast(x),
+ NO_PARSE_RESTRICTION, kNoSourcePosition));
RETURN_RESULT_OR_FAILURE(
isolate,
Execution::Call(isolate, function, target_global_proxy, 0, nullptr));

Powered by Google App Engine
This is Rietveld 408576698