Chromium Code Reviews| Index: src/api.cc |
| diff --git a/src/api.cc b/src/api.cc |
| index 688e96136e91517a1fe9844af3980ff38313ca20..9c0167e7efcbbe0f0e240f2b7336b8a290c660ab 100644 |
| --- a/src/api.cc |
| +++ b/src/api.cc |
| @@ -2262,12 +2262,13 @@ MaybeLocal<Function> ScriptCompiler::CompileFunctionInContext( |
| column_offset = static_cast<int>(source->resource_column_offset->Value()); |
| } |
| i::Handle<i::JSFunction> fun; |
| + // TODO(jwolfe): restrict parameters_end_pos? |
|
Dan Ehrenberg
2016/12/06 00:32:13
Could you elaborate a bit more in this TODO? Why w
jwolfe
2017/01/13 00:28:47
I just did it, and it seems like the right thing t
|
| has_pending_exception = |
| !i::Compiler::GetFunctionFromEval( |
| source_string, outer_info, context, i::SLOPPY, |
| - i::ONLY_SINGLE_FUNCTION_LITERAL, eval_scope_position, eval_position, |
| - line_offset, column_offset - scope_position, name_obj, |
| - source->resource_options) |
| + i::ONLY_SINGLE_FUNCTION_LITERAL, i::kNoSourcePosition, |
| + eval_scope_position, eval_position, line_offset, |
| + column_offset - scope_position, name_obj, source->resource_options) |
| .ToHandle(&fun); |
| if (has_pending_exception) { |
| isolate->ReportPendingMessages(); |