Reuse Website objects in WebsitePermissionFetcher.

Reuse Website objects in WebsitePermissionFetcher.

This patch is a rewrite of r404778. Instead of creating a new Website
instance of each permission they are now reused to collect all
permissions associated with an origin/embedder pair.

The callback from WebsitePermissionFetcher is now also substantially
simpler because it turns out that no callers actually cared about
receiving the maps it was generating. All they wanted was a collection
of Websites.

BUG=430999, 601627
Committed: https://crrev.com/fc4b6a7702df12a0f1f55122e13231f1c4c7ebff
Cr-Commit-Position: refs/heads/master@{#406966}

[Reilly Grant (use Gerrit), 2016-07-19 02:01:23]

reillyg@chromium.org changed reviewers:
+ twellington@chromium.org

[Reilly Grant (use Gerrit), 2016-07-19 02:01:24]

Please take a look.

[Reilly Grant (use Gerrit), 2016-07-19 02:01:28]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 02:02:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 03:20:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 03:20:36]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2016-07-20 21:32:01]

Description was changed from

==========
Reuse Website objects in WebsitePermissionFetcher.

In r404778 I tried to get the WebsitePermissionFetcher to reuse existing
Website objects when collecting permissions for a single site but each
object still only held information about one kind of permission. This
patch implements this properly. The interface is now also substancially
simpler because it turns out that no callers actually cared about
recieving the maps it was generating. All they wanted was a collection
of Websites.

BUG=628986
==========

to

==========
Reuse Website objects in WebsitePermissionFetcher.

This patch is a rewrite of r404778. Instead of creating a new Website
instance of each permission they are now reused to collect all
permissions associated with an origin/embedder pair.

The callback from WebsitePermissionFetcher is now also substantially
simpler because it turns out that no callers actually cared about
receiving the maps it was generating. All they wanted was a collection
of Websites.

BUG=430999,601627
==========

[Reilly Grant (use Gerrit), 2016-07-20 21:33:34]

Please take another look. I think I've resolved the issue you observed with
patch 1.

[Reilly Grant (use Gerrit), 2016-07-20 21:33:39]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:34:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 21:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:47:36]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Theresa, 2016-07-21 16:21:02]

lgtm

+finnur fyi on website settings

+dmurph fyi on ManageSpaceActivity changes

https://codereview.chromium.org/2156273003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
(right):

https://codereview.chromium.org/2156273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java:129:
// First we scan origins to get settings from there.
nit: This comment needs to be updated

https://codereview.chromium.org/2156273003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
(right):

https://codereview.chromium.org/2156273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:195:
// This nested loop looks expensive, but the amount of data is likely to be
relatively
nit: no longer a nested loop :)

[Reilly Grant (use Gerrit), 2016-07-21 18:21:11]

https://codereview.chromium.org/2156273003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
(right):

https://codereview.chromium.org/2156273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java:129:
// First we scan origins to get settings from there.
On 2016/07/21 at 16:21:01, Theresa Wellington wrote:
> nit: This comment needs to be updated

Done.

https://codereview.chromium.org/2156273003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
(right):

https://codereview.chromium.org/2156273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:195:
// This nested loop looks expensive, but the amount of data is likely to be
relatively
On 2016/07/21 at 16:21:01, Theresa Wellington wrote:
> nit: no longer a nested loop :)

Done.

[Reilly Grant (use Gerrit), 2016-07-21 18:21:16]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 18:21:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 18:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:41:24]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Reilly Grant (use Gerrit), 2016-07-21 20:05:47]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 20:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 20:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:15:58]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Reilly Grant (use Gerrit), 2016-07-21 21:29:15]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 21:29:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-07-21 21:57:32]

The CQ bit was unchecked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-07-21 21:57:35]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-07-21 21:57:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2156273003/#ps80001
(title: "Fix findbugs warnings.")

[commit-bot: I haz the power, 2016-07-21 21:58:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 22:18:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-21 22:22:46]

Description was changed from

==========
Reuse Website objects in WebsitePermissionFetcher.

This patch is a rewrite of r404778. Instead of creating a new Website
instance of each permission they are now reused to collect all
permissions associated with an origin/embedder pair.

The callback from WebsitePermissionFetcher is now also substantially
simpler because it turns out that no callers actually cared about
receiving the maps it was generating. All they wanted was a collection
of Websites.

BUG=430999,601627
==========

to

==========
Reuse Website objects in WebsitePermissionFetcher.

This patch is a rewrite of r404778. Instead of creating a new Website
instance of each permission they are now reused to collect all
permissions associated with an origin/embedder pair.

The callback from WebsitePermissionFetcher is now also substantially
simpler because it turns out that no callers actually cared about
receiving the maps it was generating. All they wanted was a collection
of Websites.

BUG=430999,601627

Committed: https://crrev.com/fc4b6a7702df12a0f1f55122e13231f1c4c7ebff
Cr-Commit-Position: refs/heads/master@{#406966}
==========

[commit-bot: I haz the power, 2016-07-21 22:22:47]

Patchset 5 (id:??) landed as
https://crrev.com/fc4b6a7702df12a0f1f55122e13231f1c4c7ebff
Cr-Commit-Position: refs/heads/master@{#406966}