Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2170123002: Reland: Add USB device permissions to individual site settings on Android. (Closed)

Created:
4 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Add USB device permissions to individual site settings on Android. This patch makes it possible to view and revoke permission to access a USB device by going to an origin's "site settings" page. This is a reland of r405887. BUG=430999, 601627 Committed: https://crrev.com/dab75c76cbefbf6355f6c8e6e013b741bf6ad4ef Cr-Commit-Position: refs/heads/master@{#407224}

Patch Set 1 #

Patch Set 2 : Resolved merge conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -6 lines) Patch
A chrome/android/java/res/drawable-hdpi/settings_usb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/settings_usb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/settings_usb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/settings_usb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/settings_usb.png View Binary file 0 comments Download
A + chrome/android/java/res/layout/usb_permission.xml View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java View 1 9 chunks +48 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java View 1 chunk +52 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java View 1 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java View 3 chunks +24 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 4 chunks +58 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
Reilly Grant (use Gerrit)
Please take a look. This is just a reland of the original patch except that ...
4 years, 5 months ago (2016-07-21 21:48:16 UTC) #3
Bernhard Bauer
LGTM FWIW, for relands it can be very useful to upload the unmodified old CL ...
4 years, 5 months ago (2016-07-22 14:16:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170123002/20001
4 years, 5 months ago (2016-07-22 17:27:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/109123) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-22 17:30:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170123002/40001
4 years, 5 months ago (2016-07-22 17:57:43 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-22 19:09:38 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 19:11:30 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dab75c76cbefbf6355f6c8e6e013b741bf6ad4ef
Cr-Commit-Position: refs/heads/master@{#407224}

Powered by Google App Engine
This is Rietveld 408576698