chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 215623002: Enable Error Console for ADT and <= Dev Channel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 215623002: Enable Error Console for ADT and <= Dev Channel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index bdb8b95b856fb00399c0a6b217eb9ae7a0823522..1e3a954a2bb22beea60f7c97570956469ff7e8bf 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -339,7 +339,7 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(

// redundant).

ErrorConsole* error_console =

ErrorConsole::Get(extension_service_->profile());

- if (error_console->enabled()) {

+ if (error_console->IsEnabledForChromeExtensionsPage()) {

const ErrorList& errors =

error_console->GetErrorsForExtension(extension->id());

if (!errors.empty()) {