chrome/browser/extensions/error_console/error_console_browsertest.cc - Issue 215623002: Enable Error Console for ADT and <= Dev Channel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 215623002: Enable Error Console for ADT and <= Dev Channel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/error_console/error_console.cc ('K') | « chrome/browser/extensions/error_console/error_console.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/error_console/error_console_browsertest.cc

diff --git a/chrome/browser/extensions/error_console/error_console_browsertest.cc b/chrome/browser/extensions/error_console/error_console_browsertest.cc

index e9eb1bed89e46b2a7b9a124e720ba75fe95e3a69..04ef8fd49796bb28d94d8ddcf1fea631506e3ffe 100644

--- a/chrome/browser/extensions/error_console/error_console_browsertest.cc

+++ b/chrome/browser/extensions/error_console/error_console_browsertest.cc

@@ -203,7 +203,8 @@ class ErrorConsoleBrowserTest : public ExtensionBrowserTest {

ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();

// We need to enable the ErrorConsole FeatureSwitch in order to collect

- // errors.

+ // errors. This should be enabled on any channel <= Dev, but let's make

+ // sure (in case a test is running on, e.g., a beta channel).

not at google - send to devlin 2014/03/31 18:52:43 you can use FeatureChannel::ScopedChannelOverride(

FeatureSwitch::error_console()->SetOverrideValue(

FeatureSwitch::OVERRIDE_ENABLED);

}