Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/gn/target.cc

Issue 2156173003: Re-land r406064 "[GN] Add JSON project writer". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clear dependency Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/json_project_writer.cc ('k') | tools/gn/visibility.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index aa1fcf6da31d3c0a6cc719136eab975dc2c5dbc0..9851035b6f63fe7dba20ff7f3d1a689124a6da70 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -14,6 +14,7 @@
#include "tools/gn/config_values_extractors.h"
#include "tools/gn/deps_iterator.h"
#include "tools/gn/filesystem_utils.h"
+#include "tools/gn/functions.h"
#include "tools/gn/scheduler.h"
#include "tools/gn/source_file_type.h"
#include "tools/gn/substitution_writer.h"
@@ -215,29 +216,29 @@ Target::~Target() {
const char* Target::GetStringForOutputType(OutputType type) {
switch (type) {
case UNKNOWN:
- return "Unknown";
+ return "unknown";
case GROUP:
- return "Group";
+ return functions::kGroup;
case EXECUTABLE:
- return "Executable";
+ return functions::kExecutable;
case LOADABLE_MODULE:
- return "Loadable module";
+ return functions::kLoadableModule;
case SHARED_LIBRARY:
- return "Shared library";
+ return functions::kSharedLibrary;
case STATIC_LIBRARY:
- return "Static library";
+ return functions::kStaticLibrary;
case SOURCE_SET:
- return "Source set";
+ return functions::kSourceSet;
case COPY_FILES:
- return "Copy";
+ return functions::kCopy;
case ACTION:
- return "Action";
+ return functions::kAction;
case ACTION_FOREACH:
- return "ActionForEach";
+ return functions::kActionForEach;
case BUNDLE_DATA:
- return "Bundle data";
+ return functions::kBundleData;
case CREATE_BUNDLE:
- return "Create bundle";
+ return functions::kCreateBundle;
default:
return "";
}
« no previous file with comments | « tools/gn/json_project_writer.cc ('k') | tools/gn/visibility.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698