third_party/WebKit/Source/web/WebImageDecoder.cpp - Issue 2155973002: Save a bitmap copy when advancing to dependent GIF and WebP animation frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebImageDecoder.cpp

Issue 2155973002: Save a bitmap copy when advancing to dependent GIF and WebP animation frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: finalizePixelsAndGetImage. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebImageDecoder.cpp

diff --git a/third_party/WebKit/Source/web/WebImageDecoder.cpp b/third_party/WebKit/Source/web/WebImageDecoder.cpp

index d4ffb79860fdb46fa716543e03bcfe16962ccb62..5f783469116cb13a2510a9118756940bbd00d3af 100644

--- a/third_party/WebKit/Source/web/WebImageDecoder.cpp

+++ b/third_party/WebKit/Source/web/WebImageDecoder.cpp

@@ -105,7 +105,10 @@ WebImage WebImageDecoder::getFrameAtIndex(int index = 0) const

ImageFrame* const frameBuffer = m_private->frameBufferAtIndex(index);

if (!frameBuffer)

return WebImage();

- return WebImage(frameBuffer->bitmap());

+ SkBitmap bitmap = frameBuffer->bitmap();

+ if (frameBuffer->getStatus() == ImageFrame::FrameComplete)

+ bitmap.setImmutable();

+ return WebImage(bitmap);

}

} // namespace blink