Save a bitmap copy when advancing to dependent GIF and WebP animation frames

third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp

Index: third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp b/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
index f7be7c977446fab5a519fe9d9d098f8febe88f3c..4df00c84729643ab04e839d55d2503ef520cbb3f 100644
--- a/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
+++ b/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
@@ -72,6 +72,8 @@ static bool decodeBitmap(const void* data, size_t length, SkBitmap* result)
     if (!frame)
         return true;
     *result = frame->bitmap();

[aleksandar.stojiljkovic, 2016/09/21 20:56:57]

Original code seems to be used only by devtools.
After this patch, it should be fine to remove that skia legacy code under:

https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkPicture.cpp?...

#ifdef SK_SUPPORT_LEGACY_PICTUREINSTALLPIXELREF
class InstallProcImageDeserializer : public SkImageDeserializer {
...

Drawback: now we have unnecessary path here only - toSkSp(fromSkSp()) - this is
the price for not having fromSkSp(frame->finalizePixelsAndGetImage()) everywhere
else.

[aleksandar.stojiljkovic, 2016/09/22 09:41:19]

Done. Removed the drawback.

+    if (frame->getStatus() == ImageFrame::FrameComplete)
+        result->setImmutable();
     return true;
 }