Save a bitmap copy when advancing to dependent GIF and WebP animation frames

third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 53 matching lines @@
         ImageDecoder::AlphaPremultiplied, ImageDecoder::GammaAndColorProfileIgnored);
     if (!imageDecoder)
         return false;
 
     // No need to copy the data; this decodes immediately.
     RefPtr<SegmentReader> segmentReader = SegmentReader::createFromSkData(SkData::MakeWithoutCopy(data, length));
     imageDecoder->setData(segmentReader.release(), true);
     ImageFrame* frame = imageDecoder->frameBufferAtIndex(0);
     if (!frame)
         return true;
     *result = frame->bitmap();

[aleksandar.stojiljkovic, 2016/09/21 20:56:57]

Original code seems to be used only by devtools.
After this patch, it should be fine to remove that skia legacy code under:

https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkPicture.cpp?...

#ifdef SK_SUPPORT_LEGACY_PICTUREINSTALLPIXELREF
class InstallProcImageDeserializer : public SkImageDeserializer {
...

Drawback: now we have unnecessary path here only - toSkSp(fromSkSp()) - this is
the price for not having fromSkSp(frame->finalizePixelsAndGetImage()) everywhere
else.

[aleksandar.stojiljkovic, 2016/09/22 09:41:19]

Done. Removed the drawback.

+    if (frame->getStatus() == ImageFrame::FrameComplete)
+        result->setImmutable();
     return true;
 }
 
 PassRefPtr<PictureSnapshot> PictureSnapshot::load(const Vector<RefPtr<TilePictureStream>>& tiles)
 {
     ASSERT(!tiles.isEmpty());
     Vector<sk_sp<SkPicture>> pictures;
     pictures.reserveCapacity(tiles.size());
     FloatRect unionRect;
     for (const auto& tileStream : tiles) {
@@ skipping 91 matching lines @@
 
 std::unique_ptr<JSONArray> PictureSnapshot::snapshotCommandLog() const
 {
     const SkIRect bounds = m_picture->cullRect().roundOut();
     LoggingCanvas canvas(bounds.width(), bounds.height());
     m_picture->playback(&canvas);
     return canvas.log();
 }
 
 } // namespace blink