Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2155773002: [css-flexbox] freezeInflexibleItems has to skip out-of-flow boxes (Closed)

Created:
4 years, 5 months ago by cbiesinger
Modified:
4 years, 5 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] freezeInflexibleItems has to skip out-of-flow boxes Out-of-flow items should not be frozen. This would have problematic effects when they have flex-grow/flex-shrink set because freezing them would subtract them from our flex-grow/shrink total without having been added. This also adds some DCHECKs. R=eae@chromium.org,dgrogan@chromium.org BUG=628072 Review-Url: https://codereview.chromium.org/2146603007 Cr-Commit-Position: refs/heads/master@{#405608} (cherry picked from commit fa759873d12635a75bdbdc3d6d5967a13378f5a3) Committed: https://chromium.googlesource.com/chromium/src/+/8986d5f563027594f0f0ee7698bcb69915accd7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/max-width-violation.html View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 5 months ago (2016-07-15 19:54:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8986d5f563027594f0f0ee7698bcb69915accd7a.

Powered by Google App Engine
This is Rietveld 408576698