Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2146603007: [css-flexbox] freezeInflexibleItems has to skip out-of-flow boxes (Closed)

Created:
4 years, 5 months ago by cbiesinger
Modified:
4 years, 5 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] freezeInflexibleItems has to skip out-of-flow boxes Out-of-flow items should not be frozen. This would have problematic effects when they have flex-grow/flex-shrink set because freezing them would subtract them from our flex-grow/shrink total without having been added. This also adds some DCHECKs. R=eae@chromium.org,dgrogan@chromium.org BUG=628072 Committed: https://crrev.com/fa759873d12635a75bdbdc3d6d5967a13378f5a3 Cr-Commit-Position: refs/heads/master@{#405608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/max-width-violation.html View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
cbiesinger
4 years, 5 months ago (2016-07-14 18:47:02 UTC) #1
eae
LGTM
4 years, 5 months ago (2016-07-14 22:00:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146603007/1
4 years, 5 months ago (2016-07-14 22:02:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 22:35:15 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 22:35:28 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 22:36:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa759873d12635a75bdbdc3d6d5967a13378f5a3
Cr-Commit-Position: refs/heads/master@{#405608}

Powered by Google App Engine
This is Rietveld 408576698