chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc - Issue 2155743002: Add throbber and status text to WebBluetooth chooser UI on non-Mac desktops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

Issue 2155743002: Add throbber and status text to WebBluetooth chooser UI on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/extensions/chooser_dialog_view.cc ('K') | « chrome/browser/ui/views/extensions/chooser_dialog_view.cc ('k') | chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h » ('j') | chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

index 1b65c6ca5d52618aa25ca88e2d1584ac10e095ce..9d7b7ddc5cd5a57fe342718af08cb81bed365c52 100644

--- a/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

@@ -13,7 +13,6 @@

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/base/l10n/l10n_util.h"

-#include "ui/gfx/range/range.h"

#include "ui/views/controls/table/table_view.h"

#include "ui/views/widget/widget.h"

#include "ui/views/window/dialog_client_view.h"

@@ -79,8 +78,3 @@ IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Close) {

EXPECT_CALL(*mock_chooser_controller_, Close()).Times(1);

chooser_dialog_view_->Close();

}

-IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, ClickStyledLabelLink) {

msw 2016/07/18 23:01:31 nit: can you test the same with ChooserContentView

juncai 2016/07/19 20:42:46 Done.

- EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1);

- chooser_dialog_view_->StyledLabelLinkClicked(nullptr, gfx::Range(), 0);