Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

Issue 2155743002: Add throbber and status text to WebBluetooth chooser UI on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h" 5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "chrome/browser/chooser_controller/mock_chooser_controller.h" 8 #include "chrome/browser/chooser_controller/mock_chooser_controller.h"
9 #include "chrome/browser/extensions/extension_browsertest.h" 9 #include "chrome/browser/extensions/extension_browsertest.h"
10 #include "chrome/browser/platform_util.h" 10 #include "chrome/browser/platform_util.h"
11 #include "chrome/browser/ui/browser_window.h" 11 #include "chrome/browser/ui/browser_window.h"
12 #include "chrome/grit/generated_resources.h" 12 #include "chrome/grit/generated_resources.h"
13 #include "testing/gmock/include/gmock/gmock.h" 13 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "ui/base/l10n/l10n_util.h" 15 #include "ui/base/l10n/l10n_util.h"
16 #include "ui/gfx/range/range.h"
17 #include "ui/views/controls/table/table_view.h" 16 #include "ui/views/controls/table/table_view.h"
18 #include "ui/views/widget/widget.h" 17 #include "ui/views/widget/widget.h"
19 #include "ui/views/window/dialog_client_view.h" 18 #include "ui/views/window/dialog_client_view.h"
20 19
21 class ChooserDialogViewTest : public ExtensionBrowserTest { 20 class ChooserDialogViewTest : public ExtensionBrowserTest {
22 public: 21 public:
23 ChooserDialogViewTest() {} 22 ChooserDialogViewTest() {}
24 ~ChooserDialogViewTest() override {} 23 ~ChooserDialogViewTest() override {}
25 24
26 void SetUpOnMainThread() override { 25 void SetUpOnMainThread() override {
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 71
73 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Cancel) { 72 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Cancel) {
74 EXPECT_CALL(*mock_chooser_controller_, Cancel()).Times(1); 73 EXPECT_CALL(*mock_chooser_controller_, Cancel()).Times(1);
75 chooser_dialog_view_->Cancel(); 74 chooser_dialog_view_->Cancel();
76 } 75 }
77 76
78 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Close) { 77 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Close) {
79 EXPECT_CALL(*mock_chooser_controller_, Close()).Times(1); 78 EXPECT_CALL(*mock_chooser_controller_, Close()).Times(1);
80 chooser_dialog_view_->Close(); 79 chooser_dialog_view_->Close();
81 } 80 }
82
83 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, ClickStyledLabelLink) {
msw 2016/07/18 23:01:31 nit: can you test the same with ChooserContentView
juncai 2016/07/19 20:42:46 Done.
84 EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1);
85 chooser_dialog_view_->StyledLabelLinkClicked(nullptr, gfx::Range(), 0);
86 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698