Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5603)

Unified Diff: chrome/browser/chooser_controller/chooser_controller.h

Issue 2155743002: Add throbber and status text to WebBluetooth chooser UI on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed some unnecessary include files and forward declarations Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chooser_controller/chooser_controller.h
diff --git a/chrome/browser/chooser_controller/chooser_controller.h b/chrome/browser/chooser_controller/chooser_controller.h
index 7ed166fe8b1332c9ba822401fd03df3958b648af..2622bb3fbc658022a386981aaed465bcd6de1508 100644
--- a/chrome/browser/chooser_controller/chooser_controller.h
+++ b/chrome/browser/chooser_controller/chooser_controller.h
@@ -46,6 +46,18 @@ class ChooserController {
// since the options have already been updated.
virtual void OnOptionRemoved(size_t index) = 0;
+ // Called when the device adapter is truned on.
Reilly Grant (use Gerrit) 2016/07/15 21:55:20 s/truned/turned/
juncai 2016/07/18 20:14:16 Done.
+ virtual void AdapterOn() = 0;
+
+ // Called when the device adapter is truned off.
Reilly Grant (use Gerrit) 2016/07/15 21:55:20 s/truned/turned/
juncai 2016/07/18 20:14:16 Done.
+ virtual void AdapterOff() = 0;
+
+ // Called when refreshing options.
+ virtual void Refresh() = 0;
Reilly Grant (use Gerrit) 2016/07/15 21:55:20 I suggest calling these "RefreshInProgress" and "R
juncai 2016/07/18 20:14:16 Done.
+
+ // Called when refreshing options is complete.
+ virtual void Idle() = 0;
+
protected:
virtual ~Observer() {}
};
@@ -64,6 +76,16 @@ class ChooserController {
// The |index|th option string which is listed in the chooser.
virtual base::string16 GetOption(size_t index) const = 0;
+ // Refresh the list of options.
+ virtual void RefreshOptions() = 0;
+
+ // Returns whether the chooser controller UI needs a throbber to show its
+ // status.
+ virtual bool NeedsThrobber() const = 0;
Reilly Grant (use Gerrit) 2016/07/15 21:55:20 This seems redundant. If the set of options is ref
juncai 2016/07/18 20:14:16 Done.
+
+ // Returns whether the chooser controller UI needs a text to show its status.
+ virtual bool NeedsStatus() const = 0;
Reilly Grant (use Gerrit) 2016/07/15 21:55:20 Maybe just call this "GetStatus" and return an emp
juncai 2016/07/18 20:14:16 Done.
+
// These three functions are called just before this object is destroyed:
// Called when the user selects the |index|th element from the dialog.

Powered by Google App Engine
This is Rietveld 408576698