Add throbber and status text to WebBluetooth chooser UI on non-Mac desktops

chrome/browser/chooser_controller/chooser_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 #define CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 
@@ skipping 28 matching lines @@
     // GetOption(index) from inside a call to OnOptionAdded will see the
     // added string since the options have already been updated.
     virtual void OnOptionAdded(size_t index) = 0;
 
     // Called when GetOption(index) is no longer present, and all later
     // options have been moved earlier by 1 slot. Calling GetOption(index)
     // from inside a call to OnOptionRemoved will NOT see the removed string
     // since the options have already been updated.
     virtual void OnOptionRemoved(size_t index) = 0;
 
+    // Called when the device adapter is truned on.

[Reilly Grant (use Gerrit), 2016/07/15 21:55:20]

s/truned/turned/

[juncai, 2016/07/18 20:14:16]

Done.

+    virtual void AdapterOn() = 0;
+
+    // Called when the device adapter is truned off.

[Reilly Grant (use Gerrit), 2016/07/15 21:55:20]

s/truned/turned/

[juncai, 2016/07/18 20:14:16]

Done.

+    virtual void AdapterOff() = 0;
+
+    // Called when refreshing options.
+    virtual void Refresh() = 0;

[Reilly Grant (use Gerrit), 2016/07/15 21:55:20]

I suggest calling these "RefreshInProgress" and "RefreshComplete" or having a
single "SetRefreshing" method that takes a boolean. Same above, you can have a
single "AdapterEnabled" method.

[juncai, 2016/07/18 20:14:16]

Done.

+
+    // Called when refreshing options is complete.
+    virtual void Idle() = 0;
+
    protected:
     virtual ~Observer() {}
   };
 
   // Returns the text to be displayed in the chooser title.
   base::string16 GetTitle() const;
 
   // Returns the label for OK button.
   virtual base::string16 GetOkButtonLabel() const = 0;
 
   // The number of options users can pick from. For example, it can be
   // the number of USB/Bluetooth device names which are listed in the
   // chooser so that users can grant permission.
   virtual size_t NumOptions() const = 0;
 
   // The |index|th option string which is listed in the chooser.
   virtual base::string16 GetOption(size_t index) const = 0;
 
+  // Refresh the list of options.
+  virtual void RefreshOptions() = 0;
+
+  // Returns whether the chooser controller UI needs a throbber to show its
+  // status.
+  virtual bool NeedsThrobber() const = 0;

[Reilly Grant (use Gerrit), 2016/07/15 21:55:20]

This seems redundant. If the set of options is refreshing we should show a
throbber. The USB chooser will never be in the refreshing state. Actually, it
could be during the initial enumeration. It would be nice to have a throbber
then.

[juncai, 2016/07/18 20:14:16]

Done.

+
+  // Returns whether the chooser controller UI needs a text to show its status.
+  virtual bool NeedsStatus() const = 0;

[Reilly Grant (use Gerrit), 2016/07/15 21:55:20]

Maybe just call this "GetStatus" and return an empty string if no status text is
necessary.

[juncai, 2016/07/18 20:14:16]

Done.

+
   // These three functions are called just before this object is destroyed:
 
   // Called when the user selects the |index|th element from the dialog.
   virtual void Select(size_t index) = 0;
 
   // Called when the user presses the 'Cancel' button in the dialog.
   virtual void Cancel() = 0;
 
   // Called when the user clicks outside the dialog or the dialog otherwise
   // closes without the user taking an explicit action.
   virtual void Close() = 0;
 
   // Open help center URL.
   virtual void OpenHelpCenterUrl() const = 0;
 
   // Only one observer may be registered at a time.
   void set_observer(Observer* observer) { observer_ = observer; }
   Observer* observer() const { return observer_; }
 
  private:
   content::RenderFrameHost* const owning_frame_;
   const int title_string_id_origin_;
   const int title_string_id_extension_;
   Observer* observer_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(ChooserController);
 };
 
 #endif  // CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_