Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

Issue 2155743002: Add throbber and status text to WebBluetooth chooser UI on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unnecessary include file Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
index 1b65c6ca5d52618aa25ca88e2d1584ac10e095ce..0fb6111e3110c876b297f6ec8337975c0dd91eb9 100644
--- a/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
@@ -9,11 +9,12 @@
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/platform_util.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/views/chooser_content_view.h"
#include "chrome/grit/generated_resources.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
-#include "ui/gfx/range/range.h"
+#include "ui/views/controls/styled_label.h"
#include "ui/views/controls/table/table_view.h"
#include "ui/views/widget/widget.h"
#include "ui/views/window/dialog_client_view.h"
@@ -30,7 +31,8 @@ class ChooserDialogViewTest : public ExtensionBrowserTest {
std::unique_ptr<ChooserDialogView> chooser_dialog_view(
new ChooserDialogView(std::move(mock_chooser_controller)));
chooser_dialog_view_ = chooser_dialog_view.get();
- table_view_ = chooser_dialog_view_->table_view_for_test();
+ table_view_ = chooser_dialog_view_->chooser_content_view_for_test()
+ ->table_view_for_test();
ASSERT_TRUE(table_view_);
table_model_ = table_view_->model();
ASSERT_TRUE(table_model_);
@@ -39,6 +41,9 @@ class ChooserDialogViewTest : public ExtensionBrowserTest {
platform_util::GetViewForWindow(
browser()->window()->GetNativeWindow()));
modal_dialog->Show();
+ styled_label_ = chooser_dialog_view_->chooser_content_view_for_test()
+ ->styled_label_for_test();
+ ASSERT_TRUE(styled_label_);
}
protected:
@@ -46,6 +51,7 @@ class ChooserDialogViewTest : public ExtensionBrowserTest {
ChooserDialogView* chooser_dialog_view_;
views::TableView* table_view_;
ui::TableModel* table_model_;
+ views::StyledLabel* styled_label_;
private:
DISALLOW_COPY_AND_ASSIGN(ChooserDialogViewTest);
@@ -54,15 +60,15 @@ class ChooserDialogViewTest : public ExtensionBrowserTest {
IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, InitialState) {
// Since "No devices found." needs to be displayed on the |table_view_|,
// the number of rows is 1.
- EXPECT_EQ(table_view_->RowCount(), 1);
+ EXPECT_EQ(1, table_view_->RowCount());
EXPECT_EQ(
- table_model_->GetText(0, 0),
- l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT));
+ l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
+ table_model_->GetText(0, 0));
// |table_view_| should be disabled since there is no option shown.
EXPECT_FALSE(table_view_->enabled());
// No option selected.
- EXPECT_EQ(table_view_->SelectedRowCount(), 0);
- EXPECT_EQ(table_view_->FirstSelectedRow(), -1);
+ EXPECT_EQ(0, table_view_->SelectedRowCount());
+ EXPECT_EQ(-1, table_view_->FirstSelectedRow());
}
IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Accept) {
@@ -82,5 +88,5 @@ IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Close) {
IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, ClickStyledLabelLink) {
EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1);
- chooser_dialog_view_->StyledLabelLinkClicked(nullptr, gfx::Range(), 0);
+ styled_label_->LinkClicked(nullptr, 0);
}

Powered by Google App Engine
This is Rietveld 408576698