Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Side by Side Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

Issue 2155743002: Add throbber and status text to WebBluetooth chooser UI on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unnecessary include file Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h" 5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "chrome/browser/chooser_controller/mock_chooser_controller.h" 8 #include "chrome/browser/chooser_controller/mock_chooser_controller.h"
9 #include "chrome/browser/extensions/extension_browsertest.h" 9 #include "chrome/browser/extensions/extension_browsertest.h"
10 #include "chrome/browser/platform_util.h" 10 #include "chrome/browser/platform_util.h"
11 #include "chrome/browser/ui/browser_window.h" 11 #include "chrome/browser/ui/browser_window.h"
12 #include "chrome/browser/ui/views/chooser_content_view.h"
12 #include "chrome/grit/generated_resources.h" 13 #include "chrome/grit/generated_resources.h"
13 #include "testing/gmock/include/gmock/gmock.h" 14 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
15 #include "ui/base/l10n/l10n_util.h" 16 #include "ui/base/l10n/l10n_util.h"
16 #include "ui/gfx/range/range.h" 17 #include "ui/views/controls/styled_label.h"
17 #include "ui/views/controls/table/table_view.h" 18 #include "ui/views/controls/table/table_view.h"
18 #include "ui/views/widget/widget.h" 19 #include "ui/views/widget/widget.h"
19 #include "ui/views/window/dialog_client_view.h" 20 #include "ui/views/window/dialog_client_view.h"
20 21
21 class ChooserDialogViewTest : public ExtensionBrowserTest { 22 class ChooserDialogViewTest : public ExtensionBrowserTest {
22 public: 23 public:
23 ChooserDialogViewTest() {} 24 ChooserDialogViewTest() {}
24 ~ChooserDialogViewTest() override {} 25 ~ChooserDialogViewTest() override {}
25 26
26 void SetUpOnMainThread() override { 27 void SetUpOnMainThread() override {
27 std::unique_ptr<MockChooserController> mock_chooser_controller( 28 std::unique_ptr<MockChooserController> mock_chooser_controller(
28 new MockChooserController(nullptr)); 29 new MockChooserController(nullptr));
29 mock_chooser_controller_ = mock_chooser_controller.get(); 30 mock_chooser_controller_ = mock_chooser_controller.get();
30 std::unique_ptr<ChooserDialogView> chooser_dialog_view( 31 std::unique_ptr<ChooserDialogView> chooser_dialog_view(
31 new ChooserDialogView(std::move(mock_chooser_controller))); 32 new ChooserDialogView(std::move(mock_chooser_controller)));
32 chooser_dialog_view_ = chooser_dialog_view.get(); 33 chooser_dialog_view_ = chooser_dialog_view.get();
33 table_view_ = chooser_dialog_view_->table_view_for_test(); 34 table_view_ = chooser_dialog_view_->chooser_content_view_for_test()
35 ->table_view_for_test();
34 ASSERT_TRUE(table_view_); 36 ASSERT_TRUE(table_view_);
35 table_model_ = table_view_->model(); 37 table_model_ = table_view_->model();
36 ASSERT_TRUE(table_model_); 38 ASSERT_TRUE(table_model_);
37 views::Widget* modal_dialog = views::DialogDelegate::CreateDialogWidget( 39 views::Widget* modal_dialog = views::DialogDelegate::CreateDialogWidget(
38 chooser_dialog_view.release(), nullptr, 40 chooser_dialog_view.release(), nullptr,
39 platform_util::GetViewForWindow( 41 platform_util::GetViewForWindow(
40 browser()->window()->GetNativeWindow())); 42 browser()->window()->GetNativeWindow()));
41 modal_dialog->Show(); 43 modal_dialog->Show();
44 styled_label_ = chooser_dialog_view_->chooser_content_view_for_test()
45 ->styled_label_for_test();
46 ASSERT_TRUE(styled_label_);
42 } 47 }
43 48
44 protected: 49 protected:
45 MockChooserController* mock_chooser_controller_; 50 MockChooserController* mock_chooser_controller_;
46 ChooserDialogView* chooser_dialog_view_; 51 ChooserDialogView* chooser_dialog_view_;
47 views::TableView* table_view_; 52 views::TableView* table_view_;
48 ui::TableModel* table_model_; 53 ui::TableModel* table_model_;
54 views::StyledLabel* styled_label_;
49 55
50 private: 56 private:
51 DISALLOW_COPY_AND_ASSIGN(ChooserDialogViewTest); 57 DISALLOW_COPY_AND_ASSIGN(ChooserDialogViewTest);
52 }; 58 };
53 59
54 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, InitialState) { 60 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, InitialState) {
55 // Since "No devices found." needs to be displayed on the |table_view_|, 61 // Since "No devices found." needs to be displayed on the |table_view_|,
56 // the number of rows is 1. 62 // the number of rows is 1.
57 EXPECT_EQ(table_view_->RowCount(), 1); 63 EXPECT_EQ(1, table_view_->RowCount());
58 EXPECT_EQ( 64 EXPECT_EQ(
59 table_model_->GetText(0, 0), 65 l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
60 l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT)); 66 table_model_->GetText(0, 0));
61 // |table_view_| should be disabled since there is no option shown. 67 // |table_view_| should be disabled since there is no option shown.
62 EXPECT_FALSE(table_view_->enabled()); 68 EXPECT_FALSE(table_view_->enabled());
63 // No option selected. 69 // No option selected.
64 EXPECT_EQ(table_view_->SelectedRowCount(), 0); 70 EXPECT_EQ(0, table_view_->SelectedRowCount());
65 EXPECT_EQ(table_view_->FirstSelectedRow(), -1); 71 EXPECT_EQ(-1, table_view_->FirstSelectedRow());
66 } 72 }
67 73
68 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Accept) { 74 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Accept) {
69 EXPECT_CALL(*mock_chooser_controller_, Select(testing::_)).Times(1); 75 EXPECT_CALL(*mock_chooser_controller_, Select(testing::_)).Times(1);
70 chooser_dialog_view_->Accept(); 76 chooser_dialog_view_->Accept();
71 } 77 }
72 78
73 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Cancel) { 79 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Cancel) {
74 EXPECT_CALL(*mock_chooser_controller_, Cancel()).Times(1); 80 EXPECT_CALL(*mock_chooser_controller_, Cancel()).Times(1);
75 chooser_dialog_view_->Cancel(); 81 chooser_dialog_view_->Cancel();
76 } 82 }
77 83
78 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Close) { 84 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, Close) {
79 EXPECT_CALL(*mock_chooser_controller_, Close()).Times(1); 85 EXPECT_CALL(*mock_chooser_controller_, Close()).Times(1);
80 chooser_dialog_view_->Close(); 86 chooser_dialog_view_->Close();
81 } 87 }
82 88
83 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, ClickStyledLabelLink) { 89 IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, ClickStyledLabelLink) {
84 EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1); 90 EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1);
85 chooser_dialog_view_->StyledLabelLinkClicked(nullptr, gfx::Range(), 0); 91 styled_label_->LinkClicked(nullptr, 0);
86 } 92 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698