Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2155713004: Speculatively fix Android automerger (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
djsollen, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gyp/android_deps.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/expat.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (11 generated)
msarett
Android.mk generator is complaining that we have two targets both named "expat".
4 years, 5 months ago (2016-07-15 20:48:10 UTC) #8
f(malita)
lgtm
4 years, 5 months ago (2016-07-15 20:49:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155713004/20001
4 years, 5 months ago (2016-07-15 21:17:55 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 21:18:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/80d46ccb2868b986c88c487c20d6b64b6762d024

Powered by Google App Engine
This is Rietveld 408576698