Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2155693003:
ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest (Closed)
|
Created:
4 years, 5 months ago by robert.bradford Modified:
4 years, 5 months ago CC:
chromium-reviews, posciak+watch_chromium.org, kalyank, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest
This resolves build failures using gcc under "cros chrome-sdk" due to
-Werror=conversion-null. See bug for full build error log.
BUG=628667
TEST=ash_unittests builds under "cros chrome-sdk"
Committed: https://crrev.com/5cbb8fc51771e06048c7fa3d7a62645a84887a94
Cr-Commit-Position: refs/heads/master@{#405935}
Patch Set 1 #
Messages
Total messages: 27 (16 generated)
The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robert.bradford@intel.com changed reviewers: + jennyz@chromium.org
robert.bradford@intel.com changed required reviewers: + jennyz@chromium.org
Hi jennyz@ PTAL at this change. Thank you!
derat@chromium.org changed reviewers: + derat@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robert.bradford@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
uh, i'm pretty sure i'm a full committer... still lgtm
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest This resolves build failures using gcc under "cros chrome-sdk" due to -Werror=conversion-null. See bug for full build error log. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" ========== to ========== ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest This resolves build failures using gcc under "cros chrome-sdk" due to -Werror=conversion-null. See bug for full build error log. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" ==========
derat@chromium.org changed required reviewers: - jennyz@chromium.org
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
oh, i guess it's because you put an asterisk before jenny's username -- was there a reason for that?
Message was sent while issue was closed.
Description was changed from ========== ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest This resolves build failures using gcc under "cros chrome-sdk" due to -Werror=conversion-null. See bug for full build error log. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" ========== to ========== ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest This resolves build failures using gcc under "cros chrome-sdk" due to -Werror=conversion-null. See bug for full build error log. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest This resolves build failures using gcc under "cros chrome-sdk" due to -Werror=conversion-null. See bug for full build error log. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" ========== to ========== ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest This resolves build failures using gcc under "cros chrome-sdk" due to -Werror=conversion-null. See bug for full build error log. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" Committed: https://crrev.com/5cbb8fc51771e06048c7fa3d7a62645a84887a94 Cr-Commit-Position: refs/heads/master@{#405935} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5cbb8fc51771e06048c7fa3d7a62645a84887a94 Cr-Commit-Position: refs/heads/master@{#405935} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
