Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4183)

Unified Diff: ash/system/chromeos/power/video_activity_notifier_unittest.cc

Issue 2155693003: ash: Use EXPECT_TRUE/FALSE vs EXPECT_EQ in VideoActivityNotifierTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/chromeos/power/video_activity_notifier_unittest.cc
diff --git a/ash/system/chromeos/power/video_activity_notifier_unittest.cc b/ash/system/chromeos/power/video_activity_notifier_unittest.cc
index f564c30423ce07588ee2dd8616947d424209ba71..eaf9fc8e8c0ae6f372b8b9b1b58abf2220d517cd 100644
--- a/ash/system/chromeos/power/video_activity_notifier_unittest.cc
+++ b/ash/system/chromeos/power/video_activity_notifier_unittest.cc
@@ -48,25 +48,25 @@ TEST_F(VideoActivityNotifierTest, NotifyImmediatelyOnStateChange) {
EXPECT_FALSE(power_client_->have_video_activity_report());
notifier_->OnVideoStateChanged(VideoDetector::State::PLAYING_WINDOWED);
- EXPECT_EQ(false, power_client_->PopVideoActivityReport());
+ EXPECT_FALSE(power_client_->PopVideoActivityReport());
notifier_->OnVideoStateChanged(VideoDetector::State::PLAYING_FULLSCREEN);
- EXPECT_EQ(true, power_client_->PopVideoActivityReport());
+ EXPECT_TRUE(power_client_->PopVideoActivityReport());
notifier_->OnLockStateChanged(true);
EXPECT_FALSE(power_client_->have_video_activity_report());
notifier_->OnLockStateChanged(false);
- EXPECT_EQ(true, power_client_->PopVideoActivityReport());
+ EXPECT_TRUE(power_client_->PopVideoActivityReport());
notifier_->OnVideoStateChanged(VideoDetector::State::PLAYING_WINDOWED);
- EXPECT_EQ(false, power_client_->PopVideoActivityReport());
+ EXPECT_FALSE(power_client_->PopVideoActivityReport());
notifier_->OnVideoStateChanged(VideoDetector::State::NOT_PLAYING);
EXPECT_FALSE(power_client_->have_video_activity_report());
notifier_->OnVideoStateChanged(VideoDetector::State::PLAYING_WINDOWED);
- EXPECT_EQ(false, power_client_->PopVideoActivityReport());
+ EXPECT_FALSE(power_client_->PopVideoActivityReport());
}
// Test that powerd is notified periodically while video is ongoing.
@@ -76,19 +76,19 @@ TEST_F(VideoActivityNotifierTest, NotifyPeriodically) {
// The timer should start in response to windowed video.
notifier_->OnVideoStateChanged(VideoDetector::State::PLAYING_WINDOWED);
- EXPECT_EQ(false, power_client_->PopVideoActivityReport());
+ EXPECT_FALSE(power_client_->PopVideoActivityReport());
EXPECT_FALSE(power_client_->have_video_activity_report());
EXPECT_TRUE(notifier_->TriggerTimeoutForTest());
- EXPECT_EQ(false, power_client_->PopVideoActivityReport());
+ EXPECT_FALSE(power_client_->PopVideoActivityReport());
EXPECT_FALSE(power_client_->have_video_activity_report());
// After fullscreen video starts, the timer should start reporting that
// instead.
notifier_->OnVideoStateChanged(VideoDetector::State::PLAYING_FULLSCREEN);
- EXPECT_EQ(true, power_client_->PopVideoActivityReport());
+ EXPECT_TRUE(power_client_->PopVideoActivityReport());
EXPECT_FALSE(power_client_->have_video_activity_report());
EXPECT_TRUE(notifier_->TriggerTimeoutForTest());
- EXPECT_EQ(true, power_client_->PopVideoActivityReport());
+ EXPECT_TRUE(power_client_->PopVideoActivityReport());
EXPECT_FALSE(power_client_->have_video_activity_report());
// Locking the screen should stop the timer.
@@ -98,10 +98,10 @@ TEST_F(VideoActivityNotifierTest, NotifyPeriodically) {
// Unlocking it should restart the timer.
notifier_->OnLockStateChanged(false);
- EXPECT_EQ(true, power_client_->PopVideoActivityReport());
+ EXPECT_TRUE(power_client_->PopVideoActivityReport());
EXPECT_FALSE(power_client_->have_video_activity_report());
EXPECT_TRUE(notifier_->TriggerTimeoutForTest());
- EXPECT_EQ(true, power_client_->PopVideoActivityReport());
+ EXPECT_TRUE(power_client_->PopVideoActivityReport());
EXPECT_FALSE(power_client_->have_video_activity_report());
// The timer should stop when video video.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698