Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2155633002: [builtins] remove redundant builtins lists. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] remove redundant builtins lists. R=bmeurer@chromium.org BUG=v8:5197 Committed: https://crrev.com/c06ad0867e789d27668b07cc2c84ced40bfe1655 Cr-Commit-Position: refs/heads/master@{#37820}

Patch Set 1 #

Patch Set 2 : fix redirected addresses #

Patch Set 3 : [builtins] remove redundant builtins lists. #

Patch Set 4 : fix #

Patch Set 5 : fix #

Patch Set 6 : fix #

Patch Set 7 : attempt to fix gc mole #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -312 lines) Patch
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 4 5 5 chunks +10 lines, -35 lines 0 comments Download
M src/builtins/builtins.cc View 1 2 3 4 5 4 chunks +123 lines, -213 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/external-reference-table.h View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M src/external-reference-table.cc View 1 2 3 4 5 6 9 chunks +71 lines, -39 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 41 (24 generated)
Yang
4 years, 5 months ago (2016-07-15 08:57:18 UTC) #1
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-15 09:40:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155633002/1
4 years, 5 months ago (2016-07-15 10:07:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/4995)
4 years, 5 months ago (2016-07-15 10:13:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155633002/20001
4 years, 5 months ago (2016-07-15 10:35:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9098) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-15 11:19:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155633002/40001
4 years, 5 months ago (2016-07-15 11:31:49 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/5059) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-15 11:34:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155633002/60001
4 years, 5 months ago (2016-07-15 11:38:16 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9108) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-15 12:20:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155633002/80001
4 years, 5 months ago (2016-07-15 13:12:08 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9142) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-15 13:28:39 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155633002/100001
4 years, 5 months ago (2016-07-18 05:02:02 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9155) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-18 05:45:09 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155633002/120001
4 years, 5 months ago (2016-07-18 08:45:09 UTC) #38
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-18 08:47:13 UTC) #39
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 08:48:30 UTC) #41
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c06ad0867e789d27668b07cc2c84ced40bfe1655
Cr-Commit-Position: refs/heads/master@{#37820}

Powered by Google App Engine
This is Rietveld 408576698