Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2152923003:
[builtins] remove redundant list of generator declarations. (Closed)
|
Created:
4 years, 5 months ago by Yang Modified:
4 years, 5 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@initbuiltins Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[builtins] remove redundant list of generator declarations.
R=bmeurer@chromium.org
BUG=v8:5197
Committed: https://crrev.com/98080817bc06dd16889c7ac9a9b87752116e1c67
Cr-Commit-Position: refs/heads/master@{#37830}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase #Messages
Total messages: 25 (16 generated)
The CQ bit was checked by bmeurer@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2155633002 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2152923003/#ps20001 (title: "rebase")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2155633002 Patch 100001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2152923003/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9177) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2152923003/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [builtins] remove redundant list of generator declarations. R=bmeurer@chromium.org BUG=v8:5197 ========== to ========== [builtins] remove redundant list of generator declarations. R=bmeurer@chromium.org BUG=v8:5197 Committed: https://crrev.com/98080817bc06dd16889c7ac9a9b87752116e1c67 Cr-Commit-Position: refs/heads/master@{#37830} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/98080817bc06dd16889c7ac9a9b87752116e1c67 Cr-Commit-Position: refs/heads/master@{#37830} |
