Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2155623002: [DOM][Editing][CodeHealth] Make private Node::hasEditableStyle static local (Closed)

Created:
4 years, 5 months ago by yoichio
Modified:
4 years, 5 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DOM][Editing][CodeHealth] Make private Node::hasEditableStyle static local Node has two |hasEditableStyle|-named functions and it is very confusing. Since one is private and uses only Node-public functions, we should make it file local function. Unfortunately public |hasEditableStyle| uses it in the Node header so we need move it to Node.cpp. This is preparation to move Node::*editable* functions to core/editing BUG= Committed: https://crrev.com/0793f8f201f0a8468e6e3dc5b1a085e4161a684d Cr-Commit-Position: refs/heads/master@{#406412}

Patch Set 1 : init #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +2 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 3 chunks +44 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
yoichio
init
4 years, 5 months ago (2016-07-19 04:21:22 UTC) #1
yosin_UTC9
lgtm
4 years, 5 months ago (2016-07-19 08:23:23 UTC) #11
tkent
lgtm
4 years, 5 months ago (2016-07-19 23:21:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155623002/40001
4 years, 5 months ago (2016-07-19 23:22:34 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-19 23:29:10 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 23:29:24 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 23:30:32 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0793f8f201f0a8468e6e3dc5b1a085e4161a684d
Cr-Commit-Position: refs/heads/master@{#406412}

Powered by Google App Engine
This is Rietveld 408576698