Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2155623002: [DOM][Editing][CodeHealth] Make private Node::hasEditableStyle static local (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: init Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Node.h
diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h
index 1efce1287e4568084cc78c51e92915c2f06fee5a..73ec4a23c28629a5839f3a381a0c2cde4ee49915 100644
--- a/third_party/WebKit/Source/core/dom/Node.h
+++ b/third_party/WebKit/Source/core/dom/Node.h
@@ -419,29 +419,8 @@ public:
bool isContentEditable() const;
bool isContentRichlyEditable() const;
- bool hasEditableStyle(EditableType editableType = ContentIsEditable) const
- {
- switch (editableType) {
- case ContentIsEditable:
- return hasEditableStyle(Editable);
- case HasEditableAXRole:
- return isEditableToAccessibility(Editable);
- }
- ASSERT_NOT_REACHED();
- return false;
- }
-
- bool layoutObjectIsRichlyEditable(EditableType editableType = ContentIsEditable) const
- {
- switch (editableType) {
- case ContentIsEditable:
- return hasEditableStyle(RichlyEditable);
- case HasEditableAXRole:
- return isEditableToAccessibility(RichlyEditable);
- }
- ASSERT_NOT_REACHED();
- return false;
- }
+ bool hasEditableStyle(EditableType = ContentIsEditable) const;
+ bool layoutObjectIsRichlyEditable(EditableType = ContentIsEditable) const;
virtual LayoutRect boundingBox() const;
IntRect pixelSnappedBoundingBox() const { return pixelSnappedIntRect(boundingBox()); }
@@ -795,10 +774,6 @@ private:
void checkSlotChange();
- enum EditableLevel { Editable, RichlyEditable };
- bool hasEditableStyle(EditableLevel) const;
- bool isEditableToAccessibility(EditableLevel) const;
-
bool isUserActionElementActive() const;
bool isUserActionElementInActiveChain() const;
bool isUserActionElementHovered() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698