Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Issue 2155503003: Remove the prototype from all V8 functions that aren't constructors (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
haraken, eroman, yzshen1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Remove the prototype from all V8 functions that aren't constructors BUG=625823 R=haraken@chromium.org TBR=eroman@chromium.org,yzshen@chromium.org Review-Url: https://codereview.chromium.org/2126763002 Cr-Commit-Position: refs/heads/master@{#403888} (cherry picked from commit 596fd5ed32fdcce384a3a5f6453582919bef6528) Committed: https://chromium.googlesource.com/chromium/src/+/bf976b9ee471214c1fac69bef867b0ddda721256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M chrome/test/base/v8_unit_test.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M extensions/renderer/console.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/object_backed_native_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gin/function_template.h View 1 chunk +6 lines, -5 lines 0 comments Download
M gin/modules/module_registry.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/js/validation_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 3 chunks +8 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/Window/window-methods-construct.html View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jochen (gone - plz use gerrit)
Committed patchset #1 (id:1) manually as bf976b9ee471214c1fac69bef867b0ddda721256.
4 years, 5 months ago (2016-07-15 08:16:01 UTC) #2
eroman
lgtm
4 years, 5 months ago (2016-07-15 17:24:04 UTC) #3
haraken
4 years, 5 months ago (2016-07-16 01:22:07 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698