Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2155353002: Try again to flip the official mac builders to GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try again to flip the official mac builders to GN. R=rsesek@chromium.org BUG=623685 Committed: https://crrev.com/b231bcf64216a6d0d52f9e1017560c0d4720a5f3 Cr-Commit-Position: refs/heads/master@{#406294}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/mb/mb_config.pyl View 5 chunks +6 lines, -6 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 16 (6 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-18 23:13:18 UTC) #1
Robert Sesek
https://codereview.chromium.org/2155353002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2155353002/diff/1/tools/mb/mb_config.pyl#newcode17 tools/mb/mb_config.pyl:17: 'Mac': 'noswarming_gn_release_bot_mac_strip', Did you want to set save_unstripped_output = ...
4 years, 5 months ago (2016-07-18 23:18:58 UTC) #4
Dirk Pranke
On 2016/07/18 23:18:58, Robert Sesek wrote: > https://codereview.chromium.org/2155353002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2155353002/diff/1/tools/mb/mb_config.pyl#newcode17 ...
4 years, 5 months ago (2016-07-18 23:27:57 UTC) #5
Robert Sesek
OK, lgtm
4 years, 5 months ago (2016-07-18 23:31:47 UTC) #6
Dirk Pranke
On 2016/07/18 23:31:47, Robert Sesek wrote: > OK, lgtm Follow-up CL: https://codereview.chromium.org/2163533002/
4 years, 5 months ago (2016-07-19 00:14:03 UTC) #7
Dirk Pranke
I'm going to wait until morning to land this at this point ...
4 years, 5 months ago (2016-07-19 03:20:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155353002/1
4 years, 5 months ago (2016-07-19 16:36:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 16:42:20 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 16:42:25 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 16:45:15 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b231bcf64216a6d0d52f9e1017560c0d4720a5f3
Cr-Commit-Position: refs/heads/master@{#406294}

Powered by Google App Engine
This is Rietveld 408576698