Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2154343004: Try again to flip Win x86, x64 official builders to GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_mac_official
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try again to flip Win x86, x64 official builders to GN. R=sebmarchand@chromium.org, brucedawson@chromium.org, brettw@chromium.org BUG=623659 Committed: https://crrev.com/1b52a97e191717c23f45eee11b13d565b88a5811 Cr-Commit-Position: refs/heads/master@{#406299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +20 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
Dirk Pranke
first to stamp wins ... this needs to wait until after https://codereview.chromium.org/2152333002/ lands, though.
4 years, 5 months ago (2016-07-18 23:14:07 UTC) #1
brucedawson
lgtm
4 years, 5 months ago (2016-07-19 00:26:33 UTC) #2
brettw
lgtm
4 years, 5 months ago (2016-07-19 01:23:55 UTC) #3
Sébastien Marchand
lgtm !
4 years, 5 months ago (2016-07-19 14:06:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154343004/1
4 years, 5 months ago (2016-07-19 17:04:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 17:12:05 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 17:12:17 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b52a97e191717c23f45eee11b13d565b88a5811 Cr-Commit-Position: refs/heads/master@{#406299}
4 years, 5 months ago (2016-07-19 17:15:22 UTC) #14
Dirk Pranke
4 years, 5 months ago (2016-07-20 01:16:00 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2161353002/ by dpranke@chromium.org.

The reason for reverting is: More official build failures. See the bug for
logs..

Powered by Google App Engine
This is Rietveld 408576698