Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 215533004: Revert of Make start/stop loading notifications per-frame (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, aboxhall, abarth-chromium, dglazkov+blink, dmazzoni, gavinp+loader_chromium.org, Nate Chapin
Visibility:
Public.

Description

Revert of Make start/stop loading notifications per-frame (https://codereview.chromium.org/183793002/) Reason for revert: Possibly causing content_browsertests EndToEnd to fail. See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio Output: [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x000000a593be base::debug::StackTrace::StackTrace() #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f9c3e4ab4a0 <unknown> #3 0x7f9c3e55da43 __poll #4 0x7f9c42aabff6 <unknown> #5 0x7f9c42aac124 g_main_context_iteration #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() #7 0x000000a8e802 base::RunLoop::Run() #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() Original issue's description: > Make start/stop loading notifications per-frame > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 TBR=abarth@chromium.org,japhet@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -94 lines) Patch
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 2 chunks +10 lines, -5 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 3 chunks +51 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/loader/ProgressTracker.h View 3 chunks +8 lines, -6 lines 0 comments Download
M Source/core/loader/ProgressTracker.cpp View 8 chunks +61 lines, -36 lines 0 comments Download
M Source/core/page/Page.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 2 chunks +23 lines, -16 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +0 lines, -9 lines 0 comments Download
M public/web/WebViewClient.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
enne (OOO)
Created Revert of Make start/stop loading notifications per-frame
6 years, 9 months ago (2014-03-27 23:00:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/215533004/1
6 years, 9 months ago (2014-03-27 23:00:34 UTC) #2
commit-bot: I haz the power
Change committed as 170218
6 years, 9 months ago (2014-03-27 23:01:42 UTC) #3
tkent
6 years, 9 months ago (2014-03-28 02:15:54 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/216083002/ by tkent@chromium.org.

The reason for reverting is: r170192 was not a culprit.
.

Powered by Google App Engine
This is Rietveld 408576698