src/compiler/representation-change.cc - Issue 2155323003: [turbofan] Properly handle bit->float64 representation changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/representation-change.cc

Issue 2155323003: [turbofan] Properly handle bit->float64 representation changes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Uncement Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/representation-change.cc

diff --git a/src/compiler/representation-change.cc b/src/compiler/representation-change.cc

index ba75a3388fcde46c80ce77cd22feefb2d31ff234..c8a00338e2440b3ed6861dbfecddff788921e627 100644

--- a/src/compiler/representation-change.cc

+++ b/src/compiler/representation-change.cc

@@ -340,6 +340,8 @@ Node* RepresentationChanger::GetFloat64RepresentationFor(

// low 32 bits (so we can pick uint32 safely).

op = machine()->ChangeUint32ToFloat64();

}

+ } else if (output_rep == MachineRepresentation::kBit) {

+ op = machine()->ChangeUint32ToFloat64();

} else if (output_rep == MachineRepresentation::kTagged) {

if (output_type->Is(Type::Undefined())) {

return jsgraph()->Float64Constant(

« no previous file with comments | « no previous file | test/cctest/compiler/test-representation-change.cc » ('j') | no next file with comments »