Video Capture Mojo Component: Skeleton

Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/services/video_capture/public/interfaces.
* Replicate simplified versions of the C++ interfaces of VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing comments from the corresponding
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected, the originals are to be removed.
* Create empty implementations.
* Add a build target that generates the Mojo bindings.
* Do not yet hook up the build target to anything.
* Use a follow-up CL to package the component into a Mojo Shell Service and hook up the build targets.

BUG=584797
TEST=No new behavior added. Nothing new added to the build.

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device_factory.h?rcl=1468855046&l=18

Committed: https://crrev.com/d6b0e6b9d39b7e699dc4e5f22879c056ffe5adb4
Cr-Commit-Position: refs/heads/master@{#410738}

[chfremer, 2016-07-18 21:50:18]

Description was changed from

==========
* Added OWNERS file * git cl format


Added empty implementation.


Split mojom into smaller pieces.


* Moved mojom location to src/device/video * In mojom file, created/copied
skeleton of interfaces needed for VideoCaptureDeviceFactory. * Added entries to
BUILD.gn files to have bingings generated from new mojom file.


Merge branch 'master' into MojoVideoCapture


Added sketch for video_capture Mojo interface


Removed unused/duplicate includes. Improved a comment.

BUG=
==========

to

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/device/video. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies. 
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.

BUG=584797
TEST=No new behavior added. Build of new targets succeeds on local build of
device_unittests.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

[chfremer, 2016-07-18 22:03:54]

Patchset #1 (id:1) has been deleted

[chfremer, 2016-07-18 22:08:59]

Patchset #1 (id:20001) has been deleted

[chfremer, 2016-07-18 22:09:37]

Description was changed from

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/device/video. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies. 
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.

BUG=584797
TEST=No new behavior added. Build of new targets succeeds on local build of
device_unittests.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

to

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/device/video. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and copy over all comments in order to
preserve them.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.

BUG=584797
TEST=No new behavior added. Build of new targets succeeds on local build of
device_unittests.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

[chfremer, 2016-07-18 22:10:49]

chfremer@chromium.org changed reviewers:
+ emircan@chromium.org, mcasas@chromium.org

[chfremer, 2016-07-21 17:27:25]

Please hold off on this review.
To continue, we first need to land a required refactoring (see CL1.1 in the
design doc [1]).
I will post a Patch Set to update the issue here after the refactoring has
landed.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...

[chfremer, 2016-08-02 18:06:28]

Patchset #1 (id:40001) has been deleted

[chfremer, 2016-08-02 18:11:58]

Description was changed from

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/device/video. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and copy over all comments in order to
preserve them.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.

BUG=584797
TEST=No new behavior added. Build of new targets succeeds on local build of
device_unittests.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

to

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/device/video. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.
* Hook into the existing build target "device_unittests" to have the two new
targets built. This is consistent 
  with other code in src/devices.

BUG=584797
TEST=No new behavior added. Build of new targets succeeds on local build of
device_unittests.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

[chfremer, 2016-08-02 18:15:00]

Description was changed from

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/device/video. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.
* Hook into the existing build target "device_unittests" to have the two new
targets built. This is consistent 
  with other code in src/devices.

BUG=584797
TEST=No new behavior added. Build of new targets succeeds on local build of
device_unittests.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

to

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/device/video. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  NOTE: A refactoring of these interfaces has just landed [3] and the code
indexed in cs.chromium.org has not yet 
  been updated.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.
* Hook into the existing build target "device_unittests" to have the two new
targets built. This is consistent 
  with other code in src/devices.

BUG=584797
TEST=No new behavior added. Build of new targets succeeds on local build of
device_unittests.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
[3] https://codereview.chromium.org/2169013002/
==========

[chfremer, 2016-08-02 18:17:29]

This is now ready for review.

I have updated the skeleton code based on the refactoring of the
VideoCaptureDeviceFactory interfaces that has just landed [1].
[1] https://codereview.chromium.org/2169013002/

[mcasas, 2016-08-02 18:59:32]

Looking good, some comments.

Couldn't find enough time to pull capture/
out of media/ and into device/ yet, but that can
be done in // to this CL.

https://codereview.chromium.org/2155303002/diff/60001/device/video/video_capt...
File device/video/video_capture_device.mojom (right):

https://codereview.chromium.org/2155303002/diff/60001/device/video/video_capt...
device/video/video_capture_device.mojom:12:
RESOLUTION_POLICY_FIXED_ASPECT_RATIO,
Mojo will generate enum class for VideoPixelStorage,
so you can drop the RESOLUTION_POLICY prefix.
Also in the other .mojoms and/or mojom enums.

https://codereview.chromium.org/2155303002/diff/60001/device/video/video_capt...
File device/video/video_capture_device_client_impl.cc (right):

https://codereview.chromium.org/2155303002/diff/60001/device/video/video_capt...
device/video/video_capture_device_client_impl.cc:10: media::mojom::VideoFramePtr
frame) {}
Until implemented, and to prevent some misfortunate
uses, you can add in the not implemented methods, well,
a NOTIMPLEMENTED()  :)

[chfremer, 2016-08-02 20:30:25]

Addressed mcasas' comments.

https://codereview.chromium.org/2155303002/diff/60001/device/video/video_capt...
File device/video/video_capture_device.mojom (right):

https://codereview.chromium.org/2155303002/diff/60001/device/video/video_capt...
device/video/video_capture_device.mojom:12:
RESOLUTION_POLICY_FIXED_ASPECT_RATIO,
On 2016/08/02 18:59:32, mcasas wrote:
> Mojo will generate enum class for VideoPixelStorage,
> so you can drop the RESOLUTION_POLICY prefix.
> Also in the other .mojoms and/or mojom enums.

Done.

https://codereview.chromium.org/2155303002/diff/60001/device/video/video_capt...
File device/video/video_capture_device_client_impl.cc (right):

https://codereview.chromium.org/2155303002/diff/60001/device/video/video_capt...
device/video/video_capture_device_client_impl.cc:10: media::mojom::VideoFramePtr
frame) {}
On 2016/08/02 18:59:32, mcasas wrote:
> Until implemented, and to prevent some misfortunate
> uses, you can add in the not implemented methods, well,
> a NOTIMPLEMENTED()  :)

Done.

[chfremer, 2016-08-02 22:00:17]

chfremer@chromium.org changed reviewers:
+ rockot@chromium.org

[chfremer, 2016-08-02 22:00:17]

@rockot: This is the CL I intended to ask you to review :-).

I also have a question for you regarding how to expose the Mojo component. Will
ping you about that separately.

[mcasas, 2016-08-02 22:18:09]

skeleton LGTM with one comment on the folder name:
video/ is a bit too generic, sp. in the Web Platform context
capture/ could be a name, or video_capture/ would be
best, but might be too long.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_device.mojom (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:19: FREQUENCY_60HZ
Same applies here: no need for FREQUENCY_
prefix

[chfremer, 2016-08-02 22:24:20]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 22:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 22:29:05]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[emircan, 2016-08-02 22:33:49]

On 2016/08/02 22:18:09, mcasas wrote:
> skeleton LGTM with one comment on the folder name:
> video/ is a bit too generic, sp. in the Web Platform context
> capture/ could be a name, or video_capture/ would be
> best, but might be too long.
+1 on /video_capture/. lgtm % nits below.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_device_client_impl.cc (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device_client_impl.cc:11: media::mojom::VideoFramePtr
frame) {}
NOTIMPLEMENTED(); here

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_format.mojom (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_format.mojom:12: GPUMEMORYBUFFER
Remove GPUMEMORYBUFFER to keep things simple for now.  However, it would be
worthwhile to keep a VideoPixelStorage enum class. Maybe, UNKNOWN for now?

[Ken Rockot(use gerrit already), 2016-08-02 22:46:25]

I agree with comments re video_capture. Also I'd prefer the mojom live in
device/video_capture/public/interfaces

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_device.mojom (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:19: FREQUENCY_60HZ
On 2016/08/02 at 22:18:09, mcasas wrote:
> Same applies here: no need for FREQUENCY_
> prefix

Unfortunately "50HZ" isn't a valid symbol name either. Though a shorter prefix
on those would be fine (F_50HZ?), and DEFAULT can be prefix-free.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:22: struct VideoCaptureParams {
There's little value in defining a struct here if it's just used as an argument
to a single function. These fields should just be arguments to AllocateAndStart.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:29: AllocateAndStart(VideoCaptureParams
requested_config,
nit: Maybe "Allocate" is an unnecessary detail? Just "Start()?"

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:31: StopAndDeAllocate();
How about the impl just treats VideoCaptureDevice pipe closure as the signal to
"stop and deallocate". It has to do that anyway when the pipe is closed, so
adding a request for the same behavior seems unnecessary.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_device_factory.mojom (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device_factory.mojom:38: interface
VideoCaptureDeviceFactory {
nit: VideoCaptureDeviceProvider? I don't think "factory" is quite accurate

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device_factory.mojom:40: =>
(array<VideoCaptureDeviceDescriptor> descriptors);
nit: +4 space indent for line continuations.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device_factory.mojom:45:
CreateDevice(VideoCaptureDeviceDescriptor device_descriptor)
Idiomatic mojom would be

  CreateDevice(VideoCaptureDeviceDescriptor descriptor,
               VideoCaptureDevice& device_request);

with no response. Then the client can create its own pipe and use it
immediately, like:

  VideoCaptureDevicePtr device;
  provider->CreateDevice(std::move(descriptor), mojo::GetProxy(&device));
  device->Start(format, policy, frequency);

The actual IPC corresponding to Start will be sent in parallel immediately after
the one corresponding to CreateDevice. No need to write async code or wait for a
round-trip.

[chfremer, 2016-08-03 22:10:47]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 22:11:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chfremer, 2016-08-03 22:14:15]

@rockot PTAL

Fixed cause for trybot failures.
Addressed comments.
Moved from device/video -> device/video_capture.
Moved *.mojom files into subfolder public/interfaces.

In a follow-up CL I will focus on packaging this Mojo component into a Mojo
Service as described in [1].

[1]
https://docs.google.com/document/d/1U7mcQ2o25KgXfEuJSIXQUpEF6Y9134ysaqSNUcmR-...

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_device.mojom (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:19: FREQUENCY_60HZ
On 2016/08/02 22:46:25, Ken Rockot wrote:
> On 2016/08/02 at 22:18:09, mcasas wrote:
> > Same applies here: no need for FREQUENCY_
> > prefix
> 
> Unfortunately "50HZ" isn't a valid symbol name either. Though a shorter prefix
> on those would be fine (F_50HZ?), and DEFAULT can be prefix-free.

I am going with HZ_50, because I want to avoid using a prefix "F" that might
make the reader think there is some meaning to it where there is none.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:22: struct VideoCaptureParams {
On 2016/08/02 22:46:25, Ken Rockot wrote:
> There's little value in defining a struct here if it's just used as an
argument
> to a single function. These fields should just be arguments to
AllocateAndStart.

Good point. Initially I was planning to keep the interface as close to the C++
version as possible to make it easier to see the correspondence during reviews.
But it seems that the Mojo mechanics and conventions are different enough to
warrant adapting the interfaces already in this step.

Done.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:29: AllocateAndStart(VideoCaptureParams
requested_config,
On 2016/08/02 22:46:25, Ken Rockot wrote:
> nit: Maybe "Allocate" is an unnecessary detail? Just "Start()?"

Done.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device.mojom:31: StopAndDeAllocate();
Agreed, assuming that each VideoCaptureDevice instance can only be started and
stopped once, which is probably the case.

Done.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_device_client_impl.cc (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device_client_impl.cc:11: media::mojom::VideoFramePtr
frame) {}
On 2016/08/02 22:33:49, emircan wrote:
> NOTIMPLEMENTED(); here

Done.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_device_factory.mojom (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device_factory.mojom:38: interface
VideoCaptureDeviceFactory {
On 2016/08/02 22:46:25, Ken Rockot wrote:
> nit: VideoCaptureDeviceProvider? I don't think "factory" is quite accurate

I feel the term "Factory" is correct here in a sense that it creates instances
of VideoCaptureDevice, which in turn represent access to a physical device. Is
your concern that it could be understood to mean that it creates actual devices?

Note, that we may later want to include "virtual" capture devices that capture
screens, windows, or tabs.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device_factory.mojom:40: =>
(array<VideoCaptureDeviceDescriptor> descriptors);
On 2016/08/02 22:46:25, Ken Rockot wrote:
> nit: +4 space indent for line continuations.

Done.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_device_factory.mojom:45:
CreateDevice(VideoCaptureDeviceDescriptor device_descriptor)
On 2016/08/02 22:46:25, Ken Rockot wrote:
> Idiomatic mojom would be
> 
>   CreateDevice(VideoCaptureDeviceDescriptor descriptor,
>                VideoCaptureDevice& device_request);
> 
> with no response. Then the client can create its own pipe and use it
> immediately, like:
> 
>   VideoCaptureDevicePtr device;
>   provider->CreateDevice(std::move(descriptor), mojo::GetProxy(&device));
>   device->Start(format, policy, frequency);
> 
> The actual IPC corresponding to Start will be sent in parallel immediately
after
> the one corresponding to CreateDevice. No need to write async code or wait for
a
> round-trip.

Thanks. That is really smart and I wouldn't have thought of it.

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
File device/video/video_capture_format.mojom (right):

https://codereview.chromium.org/2155303002/diff/80001/device/video/video_capt...
device/video/video_capture_format.mojom:12: GPUMEMORYBUFFER
On 2016/08/02 22:33:49, emircan wrote:
> Remove GPUMEMORYBUFFER to keep things simple for now.  However, it would be
> worthwhile to keep a VideoPixelStorage enum class. Maybe, UNKNOWN for now?

I'd like to keep the enum value around for the skeleton. When it comes to
filling-in the implementation it is good to know that there will be difficulties
supporting this over IPC/Mojo. Let us consider removing it then.

[commit-bot: I haz the power, 2016-08-03 22:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 22:26:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chfremer, 2016-08-03 22:57:58]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 22:58:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 23:45:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 23:45:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chfremer, 2016-08-05 17:03:58]

Description was changed from

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/device/video. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  NOTE: A refactoring of these interfaces has just landed [3] and the code
indexed in cs.chromium.org has not yet 
  been updated.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.
* Hook into the existing build target "device_unittests" to have the two new
targets built. This is consistent 
  with other code in src/devices.

BUG=584797
TEST=No new behavior added. Build of new targets succeeds on local build of
device_unittests.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
[3] https://codereview.chromium.org/2169013002/
==========

to

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/services/video_capture/public/interfaces. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.
* Do not yet hook up the build targets to anything.
* Use a follow-up CL to package the component into a Mojo Shell Service and hook
up the build targets.

BUG=584797
TEST=No new behavior added. Nothing new added to the build.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

[chfremer, 2016-08-05 17:07:01]

Description was changed from

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/services/video_capture/public/interfaces. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Add a build target that compiles the empty implementations into a component.
* Do not yet hook up the build targets to anything.
* Use a follow-up CL to package the component into a Mojo Shell Service and hook
up the build targets.

BUG=584797
TEST=No new behavior added. Nothing new added to the build.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

to

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/services/video_capture/public/interfaces. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Do not yet hook up the build target to anything.
* Use a follow-up CL to package the component into a Mojo Shell Service and hook
up the build targets.

BUG=584797
TEST=No new behavior added. Nothing new added to the build.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

[chfremer, 2016-08-05 17:09:46]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:10:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chfremer, 2016-08-05 17:14:39]

chfremer@chromium.org changed reviewers:
+ ben@chromium.org

[chfremer, 2016-08-05 17:14:40]

ben@chromium.org: As per our e-mail conversation with Ken, I would like to place
this into src/services/video_capture. Can I get a Rubber Stamp?

The newly added code is not currently hooked up to build. I am planning to
package and build this as a shell service in a follow-up CL.

@Ken, would you like to have another look or are you okay with submit?

[commit-bot: I haz the power, 2016-08-05 18:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:19:23]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-08-08 19:20:48]

RS LGTM - It's a little weird IMHO to land code that isn't built or tested at
all, but given the follow-up patch, it seems fine enough to me and I don't want
to block this.

[Ben Goodger (Google), 2016-08-08 22:54:11]

lgtm

[chfremer, 2016-08-08 23:09:17]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2016-08-08 23:09:18]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org,
emircan@chromium.org
Link to the patchset: https://codereview.chromium.org/2155303002/#ps220001
(title: "Remove build target for skeleton implementation.")

[commit-bot: I haz the power, 2016-08-08 23:09:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:18:20]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[chfremer, 2016-08-08 23:27:56]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2016-08-08 23:27:57]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
mcasas@chromium.org, ben@chromium.org, emircan@chromium.org
Link to the patchset: https://codereview.chromium.org/2155303002/#ps240001
(title: "Merge branch 'master' into VideoMojoSkeleton2")

[commit-bot: I haz the power, 2016-08-08 23:28:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:38:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:38:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chfremer, 2016-08-08 23:50:06]

chfremer@chromium.org changed reviewers:
+ tsepez@chromium.org

[chfremer, 2016-08-08 23:50:08]

tsepez@ Please review the *.mojom files as per ipc/SECURITY_OWNERS

[Tom Sepez, 2016-08-09 16:53:33]

mojom LGTM, though I would like to see the comments present.

[chfremer, 2016-08-09 17:18:34]

The CQ bit was checked by chfremer@chromium.org

[commit-bot: I haz the power, 2016-08-09 17:19:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 17:58:16]

Description was changed from

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/services/video_capture/public/interfaces. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Do not yet hook up the build target to anything.
* Use a follow-up CL to package the component into a Mojo Shell Service and hook
up the build targets.

BUG=584797
TEST=No new behavior added. Nothing new added to the build.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

to

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/services/video_capture/public/interfaces. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Do not yet hook up the build target to anything.
* Use a follow-up CL to package the component into a Mojo Shell Service and hook
up the build targets.

BUG=584797
TEST=No new behavior added. Nothing new added to the build.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

[commit-bot: I haz the power, 2016-08-09 17:58:18]

Committed patchset #10 (id:240001)

[commit-bot: I haz the power, 2016-08-09 18:01:14]

Description was changed from

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/services/video_capture/public/interfaces. 
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding 
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations. 
* Add a build target that generates the Mojo bindings. 
* Do not yet hook up the build target to anything.
* Use a follow-up CL to package the component into a Mojo Shell Service and hook
up the build targets.

BUG=584797
TEST=No new behavior added. Nothing new added to the build.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...
==========

to

==========
Video Capture Mojo Component: Skeleton

For the bigger picture, please refer to the design document at [1].

* Create Mojo interfaces in src/services/video_capture/public/interfaces.
* Replicate simplified versions of the C++ interfaces of
VideoCaptureDeviceFactory [2] and its dependencies.
  Keep interfaces close to originals and avoid name changes for now.
  Keep *.mojom files clear of comments for now. Intend to move over existing
comments from the corresponding
  *.h at a later time.
  When the Mojo component has proven stable and all usages have been redirected,
the originals are to be removed.
* Create empty implementations.
* Add a build target that generates the Mojo bindings.
* Do not yet hook up the build target to anything.
* Use a follow-up CL to package the component into a Mojo Shell Service and hook
up the build targets.

BUG=584797
TEST=No new behavior added. Nothing new added to the build.

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...

Committed: https://crrev.com/d6b0e6b9d39b7e699dc4e5f22879c056ffe5adb4
Cr-Commit-Position: refs/heads/master@{#410738}
==========

[commit-bot: I haz the power, 2016-08-09 18:01:15]

Patchset 10 (id:??) landed as
https://crrev.com/d6b0e6b9d39b7e699dc4e5f22879c056ffe5adb4
Cr-Commit-Position: refs/heads/master@{#410738}