device/video/video_capture_format.mojom - Issue 2155303002: Video Capture Mojo Component: Skeleton

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/video/video_capture_format.mojom

Issue 2155303002: Video Capture Mojo Component: Skeleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed mcasas' comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module device.mojom;

	6

	7 import "media/mojo/interfaces/media_types.mojom";

	8 import "ui/gfx/geometry/mojo/geometry.mojom";

	9

	10 enum VideoPixelStorage {

	11 CPU,

	12 GPUMEMORYBUFFER
	emircan 2016/08/02 22:33:49 Remove GPUMEMORYBUFFER to keep things simple for n Remove GPUMEMORYBUFFER to keep things simple for now. However, it would be worthwhile to keep a VideoPixelStorage enum class. Maybe, UNKNOWN for now? chfremer 2016/08/03 22:14:15 I'd like to keep the enum value around for the ske Show quoted text On 2016/08/02 22:33:49, emircan wrote: > Remove GPUMEMORYBUFFER to keep things simple for now. However, it would be > worthwhile to keep a VideoPixelStorage enum class. Maybe, UNKNOWN for now? I'd like to keep the enum value around for the skeleton. When it comes to filling-in the implementation it is good to know that there will be difficulties supporting this over IPC/Mojo. Let us consider removing it then.
	13 };

	14

	15 struct VideoCaptureFormat {

	16 gfx.mojom.Size frame_size;

	17 float frame_rate;

	18 media.mojom.VideoFormat pixel_format;

	19 VideoPixelStorage pixel_storage;

	20 };

	21

OLD	NEW