Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

Issue 2155293002: Show the Cast toolbar icon ephemerally when Cast is in use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
index a4bbd98b39ed1fe0cd82031bee7b6399578d1b0e..027e73ae7e52e210e75021d9e18d4408aa77ed06 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
@@ -1308,7 +1308,7 @@ TEST_F(ToolbarActionsModelUnitTest, ToolbarModelPrefChange) {
observer()->inserted_count() - observer()->removed_count());
}
-TEST_F(ToolbarActionsModelUnitTest, ComponentExtensionsAddedToEnd) {
+TEST_F(ToolbarActionsModelUnitTest, ComponentExtensionsAddedToRight) {
Devlin 2016/07/26 21:59:03 If we do remove this functionality, isn't this tes
Devlin 2016/07/29 19:10:22 ping
takumif 2016/08/02 04:58:41 Removing the test.
Init();
ASSERT_TRUE(AddBrowserActionExtensions());
@@ -1332,10 +1332,10 @@ TEST_F(ToolbarActionsModelUnitTest, ComponentExtensionsAddedToEnd) {
.Build();
service()->AddExtension(component_extension.get());
- EXPECT_EQ(component_extension.get()->id(), GetActionIdAtIndex(0));
- EXPECT_EQ(browser_action_a()->id(), GetActionIdAtIndex(1));
- EXPECT_EQ(browser_action_b()->id(), GetActionIdAtIndex(2));
- EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(3));
+ EXPECT_EQ(browser_action_a()->id(), GetActionIdAtIndex(0));
+ EXPECT_EQ(browser_action_b()->id(), GetActionIdAtIndex(1));
+ EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(2));
+ EXPECT_EQ(component_extension.get()->id(), GetActionIdAtIndex(3));
}
// Test various different reorderings, removals, and reinsertions of the

Powered by Google App Engine
This is Rietveld 408576698