Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model.cc

Issue 2155293002: Show the Cast toolbar icon ephemerally when Cast is in use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_actions_model.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model.cc b/chrome/browser/ui/toolbar/toolbar_actions_model.cc
index 7f2317370ad27c596cc182e0eef1334ae1ab6112..6ad8d164e234f9733bc01f565efde81df79d87d9 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_model.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_model.cc
@@ -343,7 +343,7 @@ void ToolbarActionsModel::AddItem(const ToolbarItem& item, bool is_component) {
// extensions go at their previous position.
size_t new_index = 0;
if (is_new_extension) {
- new_index = is_component ? 0 : visible_icon_count();
msw 2016/07/26 19:59:32 nit: note this tangential behavior change in the C
Devlin 2016/07/26 21:59:03 FYI, this also breaks behavior we had in place for
takumif 2016/07/28 20:04:11 I wasn't aware that there are/were component actio
Devlin 2016/07/29 19:10:22 Yes, this was just for stars, so I think we're pro
takumif 2016/08/02 04:58:41 Done changing the description.
+ new_index = visible_icon_count();
// For the last-known position, we use the index of the extension that is
// just before this extension, plus one. (Note that this isn't the same
// as new_index + 1, because last_known_positions_ can include disabled

Powered by Google App Engine
This is Rietveld 408576698