chrome/browser/ui/toolbar/toolbar_actions_model.cc - Issue 2155293002: Show the Cast toolbar icon ephemerally when Cast is in use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model.cc

Issue 2155293002: Show the Cast toolbar icon ephemerally when Cast is in use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/toolbar/media_router_contextual_menu.cc ('K') | « chrome/browser/ui/toolbar/toolbar_actions_bar.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc » ('j') | chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_actions_model.cc

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model.cc b/chrome/browser/ui/toolbar/toolbar_actions_model.cc

index 7f2317370ad27c596cc182e0eef1334ae1ab6112..6ad8d164e234f9733bc01f565efde81df79d87d9 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_model.cc

+++ b/chrome/browser/ui/toolbar/toolbar_actions_model.cc

@@ -343,7 +343,7 @@ void ToolbarActionsModel::AddItem(const ToolbarItem& item, bool is_component) {

// extensions go at their previous position.

size_t new_index = 0;

if (is_new_extension) {

- new_index = is_component ? 0 : visible_icon_count();

+ new_index = visible_icon_count();

// For the last-known position, we use the index of the extension that is

// just before this extension, plus one. (Note that this isn't the same

// as new_index + 1, because last_known_positions_ can include disabled