Make it possible for downstream projects to easily set the default fill color

Make it possible for downstream projects to easily set the default fill color

This still requires downstream patching, but the patch should be simpler now.

To test, define DEFAULT_BACKGROUND_COLOR in content/public/common/web_preferences.cc
to something like SK_ColorRED, then watch for a red flash eg when starting content_shell.

Original patch by Łukasz Lipski.

BUG=331654

[Mostyn Bramley-Moore, 2016-07-18 19:19:35]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 19:20:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mostyn Bramley-Moore, 2016-07-18 19:24:17]

Description was changed from

==========
make it possible for downstream projects to easily set the default fill color

BUG=331654
==========

to

==========
make it possible for downstream projects to easily set the default fill color

This still requires downstream patching, but the patch should be simpler now.

To test, define DEFAULT_BACKGROUND_COLOR in
content/public/common/web_preferences.cc
to something like SK_ColorRED, then watch for a red flash eg when starting
content_shell.

BUG=331654
==========

[commit-bot: I haz the power, 2016-07-18 19:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 19:57:47]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Mostyn Bramley-Moore, 2016-07-19 08:53:07]

Description was changed from

==========
make it possible for downstream projects to easily set the default fill color

This still requires downstream patching, but the patch should be simpler now.

To test, define DEFAULT_BACKGROUND_COLOR in
content/public/common/web_preferences.cc
to something like SK_ColorRED, then watch for a red flash eg when starting
content_shell.

BUG=331654
==========

to

==========
make it possible for downstream projects to easily set the default fill color

This still requires downstream patching, but the patch should be simpler now.

To test, define DEFAULT_BACKGROUND_COLOR in
content/public/common/web_preferences.cc
to something like SK_ColorRED, then watch for a red flash eg when starting
content_shell.

Original patch by Łukasz Lipski.

BUG=331654
==========

[Mostyn Bramley-Moore, 2016-07-19 14:06:46]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 14:07:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 15:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 15:29:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mostyn Bramley-Moore, 2016-07-20 23:32:41]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:33:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 00:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:55:16]

Dry run: This issue passed the CQ dry run.

[Mostyn Bramley-Moore, 2016-07-21 07:50:56]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 07:51:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mostyn Bramley-Moore, 2016-07-21 07:53:07]

mostynb@opera.com changed reviewers:
+ chrishtr@chromium.org, pdr@google.com

[Mostyn Bramley-Moore, 2016-07-21 07:53:08]

@chrishtr: please take a look- perhaps this helps with crbug.com/21798 a little?

[esprehn, 2016-07-21 08:03:10]

Description was changed from

==========
make it possible for downstream projects to easily set the default fill color

This still requires downstream patching, but the patch should be simpler now.

To test, define DEFAULT_BACKGROUND_COLOR in
content/public/common/web_preferences.cc
to something like SK_ColorRED, then watch for a red flash eg when starting
content_shell.

Original patch by Łukasz Lipski.

BUG=331654
==========

to

==========
Make it possible for downstream projects to easily set the default fill color

This still requires downstream patching, but the patch should be simpler now.

To test, define DEFAULT_BACKGROUND_COLOR in
content/public/common/web_preferences.cc
to something like SK_ColorRED, then watch for a red flash eg when starting
content_shell.

Original patch by Łukasz Lipski.

BUG=331654
==========

[commit-bot: I haz the power, 2016-07-21 08:06:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 08:06:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Mostyn Bramley-Moore, 2016-07-21 08:09:23]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 08:09:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 09:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 09:16:59]

Dry run: This issue passed the CQ dry run.

[Mostyn Bramley-Moore, 2016-07-29 06:54:43]

*ping*

[chrishtr, 2016-07-29 18:15:41]

https://codereview.chromium.org/2155273002/diff/80001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/2155273002/diff/80001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_aura.cc:499:
host_->SetBackgroundOpaque(GetBackgroundOpaque());
Why do you also need to set whether it's opaque? Isn't that set already?

[Mostyn Bramley-Moore, 2016-08-02 15:00:17]

I am OOO for two weeks to look after some family issues, I will get back to this
once I'm back.