content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 2155273002: Make it possible for downstream projects to easily set the default fill color

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2155273002: Make it possible for downstream projects to easily set the default fill color Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac fixup Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 6fdcf891b8f50706eee422addcfa1bb682ffe518..7981b9254389a6165e6f67c7bca1f2937104f643 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -494,9 +494,9 @@ RenderWidgetHostViewAura::RenderWidgetHostViewAura(RenderWidgetHost* host,

RenderViewHost* rvh = RenderViewHost::From(host_);

if (rvh) {

- // TODO(mostynb): actually use prefs. Landing this as a separate CL

- // first to rebaseline some unreliable layout tests.

- ignore_result(rvh->GetWebkitPreferences());

+ WebPreferences prefs = rvh->GetWebkitPreferences();

+ background_color_ = prefs.default_background_color;

+ host_->SetBackgroundOpaque(GetBackgroundOpaque());

chrishtr 2016/07/29 18:15:41 Why do you also need to set whether it's opaque? I

}

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »