Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2155243004: [Android]Fix a bug where long press on urlbar only copies the TLD (Closed)

Created:
4 years, 5 months ago by Ian Wen
Modified:
4 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android]Fix a bug where long press on urlbar only copies the TLD Instead of using TextView#getText, we should use Tab#getUrl() instead. BUG=629672 Committed: https://crrev.com/605bf28780bf60df121e61b4b735d8fb825ff3bf Cr-Commit-Position: refs/heads/master@{#406721}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Ian Wen
PTAL
4 years, 5 months ago (2016-07-19 23:37:59 UTC) #2
Ted C
lgtm https://codereview.chromium.org/2155243004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java File chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java (right): https://codereview.chromium.org/2155243004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java#newcode665 chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:665: ClipData clip = ClipData.newPlainText("url", tab.getUrl()); LocationBarLayout does a ...
4 years, 5 months ago (2016-07-19 23:50:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155243004/20001
4 years, 5 months ago (2016-07-20 23:05:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 00:17:24 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 00:19:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/605bf28780bf60df121e61b4b735d8fb825ff3bf
Cr-Commit-Position: refs/heads/master@{#406721}

Powered by Google App Engine
This is Rietveld 408576698