chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java - Issue 2155243004: [Android]Fix a bug where long press on urlbar only copies the TLD

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

Issue 2155243004: [Android]Fix a bug where long press on urlbar only copies the TLD (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

index 100f96c4a3c2755f0964737380778d5615a14de4..88e45bba4c49065ddd9f9122d01856a996d7138f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

@@ -343,7 +343,7 @@ public class WebsiteSettingsPopup implements OnClickListener {

public boolean onLongClick(View v) {

ClipboardManager clipboard = (ClipboardManager) mContext

.getSystemService(Context.CLIPBOARD_SERVICE);

- ClipData clip = ClipData.newPlainText("url", mUrlTitle.getText());

+ ClipData clip = ClipData.newPlainText("url", mFullUrl);

clipboard.setPrimaryClip(clip);

Toast.makeText(mContext, R.string.url_copied, Toast.LENGTH_SHORT).show();

return true;

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java » ('j') | no next file with comments »