Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm

Issue 2155233002: omnibox: make decorations non-focusable for now (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
index fe6e6ae82eb4a30dfdc3ce1c02db9cdf76fdec3b..3c7a0a85fb39382a97def596098632150ac67507 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
@@ -55,7 +55,11 @@ const CGFloat kMaterialDividerIncognitoGrayScale = 1.0;
- (BOOL)acceptsFirstResponder {
// This NSView is only focusable if the owning LocationBarDecoration can
// accept mouse presses.
- return owner_->AcceptsMousePress() ? YES : NO;
+ // TODO(ellyjones): Once the key view loop order in ToolbarController is fixed
+ // up properly (which will require some redesign of
+ // LocationBarViewMac::GetDecorationAccessibilityViews()), this method should
+ // honor |owner_->AcceptsMousePress()|. See https://crbug.com/623883.
+ return NO;
}
- (void)drawRect:(NSRect)dirtyRect {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698