Issue 2155213002: check for culled-out paths inside SkDraw

reed1

Description was changed from ========== check for culled-out paths inside SkDraw BUG=629026 ========== to ========== ...

4 years, 5 months ago (2016-07-18 16:30:33 UTC) #1

reed1

The CQ bit was checked by reed@google.com to run a CQ dry run

4 years, 5 months ago (2016-07-18 16:30:55 UTC) #4

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155213002/1

4 years, 5 months ago (2016-07-18 16:31:13 UTC) #5

f(malita)

LGTM % makeOutset https://codereview.chromium.org/2155213002/diff/1/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/2155213002/diff/1/src/core/SkDraw.cpp#newcode1023 src/core/SkDraw.cpp:1023: SkRect clipBounds = SkRect::Make(fRC->getBounds()).makeOffset(1, 1); makeOutset()

4 years, 5 months ago (2016-07-18 16:34:16 UTC) #6

reed1

The CQ bit was checked by reed@google.com to run a CQ dry run

4 years, 5 months ago (2016-07-18 16:48:48 UTC) #7

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155213002/20001

4 years, 5 months ago (2016-07-18 16:49:00 UTC) #8

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 5 months ago (2016-07-18 17:10:57 UTC) #11

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 5 months ago (2016-07-18 17:11:01 UTC) #12

reed1

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the ...

4 years, 5 months ago (2016-07-18 19:56:33 UTC) #14

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155213002/40001

4 years, 5 months ago (2016-07-18 19:56:38 UTC) #15

commit-bot: I haz the power

Description was changed from ========== check for culled-out paths inside SkDraw BUG=629026 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155213002 ========== ...

4 years, 5 months ago (2016-07-18 20:22:58 UTC) #16

commit-bot: I haz the power

4 years, 5 months ago (2016-07-18 20:22:59 UTC) #17

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/01a2ff8a325e17221b139968e337413df0c2e60c

Issue 2155213002: check for culled-out paths inside SkDraw (Closed)

Description

Patch Set 1 #

Patch Set 2 : actually test it: inverse-fill, H/V lines #

Patch Set 3 : add slop (see skbug.com/5542) #

Messages