Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 2155193002: Revert of -enable GPU Rasterization for content with any author defined viewport. (Closed)

Created:
4 years, 5 months ago by picksi1
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof, aelias_OOO_until_Jul13, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2154193002/ ) Reason for revert: Relanding this has potentially caused a layout test to fail (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8452). The build sheriff has asked me to revert it. Adding aelias & vmiura so they can do a more refined revert on their return from vacation. Original issue's description: > Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2156553002/ ) > > Reason for revert: > Reverting change now that we have collected data from telemetry. > > Original issue's description: > > Revert of Re-enable GPU Rasterization for content with any author defined viewport. (patchset #2 id:20001 of https://codereview.chromium.org/2097413003/ ) > > > > Reason for revert: > > This has caused an unexpectedly large regression in overall PSS (about 5MB, graph here: https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42bbb3740a00505e4040af2173423b0&start_rev=402061&end_rev=402790). > > The owners are both OOO and this is blocking Android release. This has already been reverted in the release branch but our infrastructure cannot gather data from the branch to confirm that the revert has had the intended result. > > > > This revert will allow us to confirm that this CL was the cause of the regression. Once confirmed (or otherwise) via telemetry dashboards this revert will be re-reverted. > > > > Original issue's description: > > > Re-enable GPU Rasterization for content with any author defined viewport. > > > > > > BUG=591179 > > > > > > Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339 > > > Cr-Commit-Position: refs/heads/master@{#402702} > > > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=591179 > > > > Committed: https://crrev.com/10a77702aa0490dfaaa6e354151b24b738474fb4 > > Cr-Commit-Position: refs/heads/master@{#405750} > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=591179 > > Committed: https://crrev.com/5f19720ded2369857bee408ab48e11e7b5d28f7b > Cr-Commit-Position: refs/heads/master@{#405974} TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591179 Committed: https://crrev.com/1ce44d25cbafd74f034c30ddfd4b0f3caed9978d Cr-Commit-Position: refs/heads/master@{#405983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M third_party/WebKit/Source/core/dom/ViewportDescription.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ViewportTest.cpp View 2 chunks +9 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/viewport/viewport-gpu-rasterization-disabled-without-viewport.html View 1 chunk +0 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/viewport/viewport-inferred-values-do-not-trigger-gpu-rasterization.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
picksi1
Created Revert of -enable GPU Rasterization for content with any author defined viewport.
4 years, 5 months ago (2016-07-18 14:08:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155193002/1
4 years, 5 months ago (2016-07-18 14:08:48 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-18 14:08:50 UTC) #5
alex clarke (OOO till 29th)
lgtm
4 years, 5 months ago (2016-07-18 14:15:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155193002/1
4 years, 5 months ago (2016-07-18 14:16:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 14:17:08 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1ce44d25cbafd74f034c30ddfd4b0f3caed9978d Cr-Commit-Position: refs/heads/master@{#405983}
4 years, 5 months ago (2016-07-18 14:20:28 UTC) #14
picksi1
4 years, 5 months ago (2016-07-18 15:39:20 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2161663002/ by picksi@chromium.org.

The reason for reverting is: CL falsely blamed for red layout test. Relanding
it..

Powered by Google App Engine
This is Rietveld 408576698