Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2097413003: Re-enable GPU Rasterization for content with any author defined viewport. (Closed)

Created:
4 years, 5 months ago by vmiura
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable GPU Rasterization for content with any author defined viewport. BUG=591179 Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339 Cr-Commit-Position: refs/heads/master@{#402702}

Patch Set 1 #

Patch Set 2 : Update unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M third_party/WebKit/Source/core/dom/ViewportDescription.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ViewportTest.cpp View 1 2 chunks +20 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/viewport/viewport-gpu-rasterization-disabled-without-viewport.html View 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/viewport/viewport-inferred-values-do-not-trigger-gpu-rasterization.html View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097413003/20001
4 years, 5 months ago (2016-06-28 17:20:06 UTC) #2
vmiura
PTAL. I'd like to get this in the pipeline for 53 and get some data ...
4 years, 5 months ago (2016-06-28 17:21:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 17:24:09 UTC) #6
chrishtr
lgtm
4 years, 5 months ago (2016-06-28 17:28:20 UTC) #7
aelias_OOO_until_Jul13
lgtm
4 years, 5 months ago (2016-06-28 20:07:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097413003/20001
4 years, 5 months ago (2016-06-28 22:58:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 03:34:11 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339 Cr-Commit-Position: refs/heads/master@{#402702}
4 years, 5 months ago (2016-06-29 03:37:13 UTC) #13
picksi1
4 years, 5 months ago (2016-07-15 10:38:35 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2156553002/ by picksi@chromium.org.

The reason for reverting is: This has caused an unexpectedly large regression in
overall PSS (about 5MB, graph here:
https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42...).

The owners are both OOO and this is blocking Android release so I am reverting
it.

.

Powered by Google App Engine
This is Rietveld 408576698